Eli Mesika has posted comments on this change. Change subject: [WIP] API: Adding BackendJobResource... ......................................................................
Patch Set 1: (4 inline comments) .................................................... File backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendJobResource.java Line 24: super(id, modelType, entityType); Line 25: } Line 26: Line 27: public BackendJobResource(String id, BackendJobsResource parent) { Line 28: super(id, org.ovirt.engine.api.model.Job.class, org.ovirt.engine.core.common.job.Job.class); Done Line 29: this.setParent(parent); Line 30: } Line 31: Line 32: @Override Line 34: return inject(new BackendActionResource(action, oid)); Line 35: } Line 36: Line 37: @Override Line 38: public Response end(Action action) { Done Line 39: return doAction(VdcActionType.EndExternalJob, Line 40: new EndExternalJobParameters(guid, JobMapper.map(action.getStatus()), action.isForce()), action); Line 41: } Line 42: .................................................... File backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendJobsResource.java Line 17: import org.ovirt.engine.core.common.queries.VdcQueryType; Line 18: import org.ovirt.engine.core.compat.Guid; Line 19: Line 20: Line 21: public class BackendJobsResource extends AbstractBackendCollectionResource<org.ovirt.engine.api.model.Job, org.ovirt.engine.core.common.job.Job> implements JobsResource { Done Line 22: Line 23: static final String[] SUB_COLLECTIONS = { "steps" }; Line 24: Line 25: public BackendJobsResource() { .................................................... File backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/AbstractBackendJobResourceTest.java Line 5: import org.junit.Test; Line 6: import org.ovirt.engine.api.model.Job; Line 7: import org.ovirt.engine.core.common.queries.IdQueryParameters; Line 8: import org.ovirt.engine.core.common.queries.VdcQueryType; Line 9: Class removed , all functionality is in BackendSubResourceTest Line 10: public abstract class AbstractBackendJobResourceTest Line 11: extends AbstractBackendSubResourceTest<Job, org.ovirt.engine.core.common.job.Job, BackendJobResource> { Line 12: Line 13: public AbstractBackendJobResourceTest(BackendJobResource jobResource) { -- To view, visit http://gerrit.ovirt.org/16166 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7474b82ecea8bd4ac34ea24fdfd1b159ef8c881f Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Michael Pasternak <mpast...@redhat.com> Gerrit-Reviewer: Ori Liel <ol...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches