Roy Golan has posted comments on this change. Change subject: packaging: make clean target use DEV_EXTRA_BUILD_FLAG ......................................................................
Patch Set 1: (1 inline comment) .................................................... File Makefile Line 194: $(MAKE) maven Line 195: Line 196: clean: Line 197: # Clean maven generated stuff: Line 198: $(MVN) clean $(EXTRA_BUILD_FLAGS) $(DEV_EXTRA_BUILD_FLAGS) Cant we have only one EXTRA_MVN_FLAGS which will be used for all mvn invocations in targets and for flexibility keep the EXTRA_BUILD_FLAGS and DEV_EXTRA_BUILD_FLAGS Line 199: rm -rf $(OUTPUT_RPMBUILD) $(OUTPUT_DIR) $(BUILD_FILE) Line 200: Line 201: # Clean files generated from templates: Line 202: rm -rf $(GENERATED) -- To view, visit http://gerrit.ovirt.org/16395 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I12d59fad2ca46a67e0c3ec0baa6189a4fb7035bf Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Alex Lourie <alou...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
