Alon Bar-Lev has posted comments on this change.
Change subject: core: i18n welcome page with branding
......................................................................
Patch Set 4: (1 inline comment)
....................................................
File packaging/branding/ovirt.brand/messages.properties
Line 46:
obrand.welcome.section1.row1.url=UserPortal/org.ovirt.engine.ui.userportal.UserPortal/UserPortal.html?locale={0}
Line 47: obrand.welcome.section1.row2.text=Administrator Portal
Line 48:
obrand.welcome.section1.row2.url=webadmin/webadmin/WebAdmin.html?locale={0}
Line 49: obrand.welcome.section1.row3.text=Reports Portal
Line 50:
obrand.welcome.section1.row3.url=OvirtEngineWeb/RedirectServlet?Page=Reports
Oh... I did not know this is jsp...
What I thought we allow customization of the entire page...
<html>
<head>
__MSG_head__
</head>
<body>
__MSG_body_head__
whatever html that may exist
__MSG_body_tail__
</body>
</html>
Now... you can simply have html within these messages (head, body_head,
body_tail) in this case... no need to perform anything special. branding can
even introduce script in the head...
However, I think that we can have this exactly the opposite... maybe we can
have the core within html message and provide different htmls within each
branding... so the branding can overwrite the entire html, leaving the main
content at some place.
<html>
<body>
<h1>My application</h1>
<h2>The menu</h2>
__MSG_menu__
<div attributes>
__MSG_locale__
</div>
</body>
</html>
--
To view, visit http://gerrit.ovirt.org/16359
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9987ed58c2e0ead9b25c5f46fb974a96bfd46d30
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alexander Wels <aw...@redhat.com>
Gerrit-Reviewer: Alexander Wels <aw...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Einav Cohen <eco...@redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gsher...@redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
