Eli Mesika has posted comments on this change.
Change subject: [WIP] API: Adding StepResource and StepsResource..
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStepsResource.java
Line 44: }
Line 45: else {
Line 46: id = step.getJob().getId();
Line 47: }
Line 48: return performCreate(VdcActionType.AddExternalStep,
Why? I don't need to map the whole entity , I am mapping exactly what I am
sending to the command , its true that its 2 calls vs 1 , but each is very
short and simple
Line 49: new
AddExternalStepParameters(Guid.createGuidFromString(id),
step.getDescription(),StepMapper.map(step.getStepType()),
StepMapper.map(step.getStatus())),
Line 50: new
QueryIdResolver<Guid>(VdcQueryType.GetStepByStepId, IdQueryParameters.class));
Line 51: }
Line 52:
--
To view, visit http://gerrit.ovirt.org/16163
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id1b95a094dc586e6ebbdacd44e0a034e91605496
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpast...@redhat.com>
Gerrit-Reviewer: Ori Liel <ol...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
