Alon Bar-Lev has posted comments on this change. Change subject: doc: rename engine_dao database to engine_dao_tests ......................................................................
Patch Set 2: (1 inline comment) .................................................... File README.developer Line 191: Create empty schema (one time): Line 192: Line 193: $ PGPASSWORD=engine \ Line 194: ./backend/manager/dbscripts/create_schema.sh \ Line 195: -d engine_dao_tests -u engine Why should it fixed? we enforce this when building. -D engine.db.url=jdbc:postgresql://localhost/engine_dao_tests" I don't really care what the default is, you can change it in different patch if you like, but changing this will effect current users. Line 196: Line 197: Upgrade schema (when needed): Line 198: Line 199: $ PGPASSWORD=engine \ -- To view, visit http://gerrit.ovirt.org/16308 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8e71806a4fe336797c9ae92a08b746884337bd80 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
