Alon Bar-Lev has posted comments on this change.
Change subject: oVirt Node Upgrade: Support N configuration
......................................................................
Patch Set 9: (2 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/OVirtNodeInfo.java
Line 22: this.path = path;
Line 23: this.minimumVersion = minimumVersion;
Line 24: }
Line 25:
Line 26: public static OVirtNodeInfo[] get() {
Just curious... why? do you expect to call this using:
OVirtNodeInfo.get(Config.resolveOVirtISOsRepositoryPath(), Config.<String>
GetValue(ConfigValues.OvirtInitialSupportedI
soVersion), Config.<String> GetValue(ConfigValues.OvirtIsoPrefix));
What is the benefit?
Line 27: final String delimiter = ":";
Line 28: final String[] path =
Config.resolveOVirtISOsRepositoryPath().split(delimiter);
Line 29: final String minimumVersion[] = Config.<String>
GetValue(ConfigValues.OvirtInitialSupportedIsoVersion).split(delimiter);
Line 30:
Line 47: log.debugFormat("NodeInfo: regex {0} path {1},
minimumVersion {2}",
Line 48: regex[i], path[i], minimumVersion[i]);
Line 49: info.add(new OVirtNodeInfo(Pattern.compile(regex[i]), new
File(path[i]), minimumVersion[i]));
Line 50: }
Line 51: return info.toArray(new OVirtNodeInfo[info.size()]);
What do you recommend? return List? I like the use of primitive types... but no
real reason it will work as-is also with List.
Line 52: }
--
To view, visit http://gerrit.ovirt.org/14756
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibfb9dc5d0dc8780b519107acbe0ae866831f782c
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsl...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsl...@redhat.com>
Gerrit-Reviewer: Michael Burns <mbu...@redhat.com>
Gerrit-Reviewer: Ravi Nori <rn...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
