Eli Mesika has posted comments on this change.

Change subject: [WIP] API: Adding BackendStepResource and ...
......................................................................


Patch Set 1: (3 inline comments)

....................................................
File 
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStepResource.java
Line 9: import org.ovirt.engine.core.common.action.VdcActionType;
Line 10: import 
org.ovirt.engine.core.common.queries.GetStepByStepIdQueryParameters;
Line 11: import org.ovirt.engine.core.common.queries.VdcQueryType;
Line 12: 
Line 13: public class BackendStepResource extends 
AbstractBackendActionableResource<org.ovirt.engine.api.model.Step, 
org.ovirt.engine.core.common.job.Step> implements StepResource{
Done
Line 14: 
Line 15:     private BackendStepsResource parent;
Line 16:     public BackendStepsResource getParent() {
Line 17:         return parent;


Line 20:     public void setParent(BackendStepsResource parent) {
Line 21:         this.parent = parent;
Line 22:     }
Line 23: 
Line 24:     public BackendStepResource(String id,
Done
Line 25:             Class<Step> modelType,
Line 26:             Class<org.ovirt.engine.core.common.job.Step> entityType,
Line 27:             String[] subCollections) {
Line 28:         super(id, modelType, entityType, subCollections);


Line 40: 
Line 41:     @Override
Line 42:     public Response end(Action action) {
Line 43:         return doAction(VdcActionType.EndExternalStep,
Line 44:                 new EndExternalStepParameters(guid, 
action.isSucceeded(), action.isForce()), action);
Indeed !!! force was removed from this command params
Line 45:     }
Line 46: 
Line 47:     @Override
Line 48:     public Step get() {


-- 
To view, visit http://gerrit.ovirt.org/16167
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5f7b7f51d113600ac9a484645da93cc16a1b6bc6
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpast...@redhat.com>
Gerrit-Reviewer: Ori Liel <ol...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to