Alon Bar-Lev has posted comments on this change. Change subject: packaging: setup: set log file for db upgrade ......................................................................
Patch Set 1: (2 inline comments) .................................................... File packaging/setup/plugins/ovirt-engine-setup/db/schema.py Line 95 Line 96 Line 97 Line 98 Line 99 see this... Line 166: '-s', self.environment[osetupcons.DBEnv.HOST], Line 167: '-p', str(self.environment[osetupcons.DBEnv.PORT]), Line 168: '-u', self.environment[osetupcons.DBEnv.USER], Line 169: '-d', self.environment[osetupcons.DBEnv.DATABASE], Line 170: '-l', os.path.join( I did a mistake not to use the same as above. Line 171: osetupcons.FileLocations.OVIRT_ENGINE_LOG_DIR, Line 172: 'engine-db-upgrade-%s.log' % Line 173: datetime.datetime.now().strftime('%Y%m%d%H%M%S'), Line 174: ), -- To view, visit http://gerrit.ovirt.org/16366 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic04a4976fdc2eaa89c245366a3fecdd52220fc91 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Alex Lourie <alou...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Moran Goldboim <mgold...@redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches