Lior Vernia has posted comments on this change.
Change subject: webadmin: Disabled VNIC properties for external networks
......................................................................
Patch Set 8: (4 inline comments)
Still remains to be verified.
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/BaseEditVmInterfaceModel.java
Line 59: getName().setEntity(getNic().getName());
Line 60: initMAC();
Line 61:
Line 62: initLinked();
Line 63:
Done
Line 64: initNetworks();
Line 65:
Line 66: initCustomPropertySheet();
Line 67:
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/EditVmInterfaceModel.java
Line 137: } else {
Line 138: return;
Line 139: }
Line 140:
Line 141: getNetwork().setIsChangable(false);
Done
Line 142: }
Line 143: }
Line 144:
Line 145: boolean isVmUp() {
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmInterfaceModel.java
Line 117: setPortMirroring(new EntityModel() {
Line 118: @Override
Line 119: public EntityModel setIsChangable(boolean value) {
Line 120: super.setIsChangable(value);
Line 121: onPropertyChanged(new
PropertyChangedEventArgs("IsChangable")); //$NON-NLS-1$
Fixed the infrastructure, will push the patch before this one.
Line 122: return this;
Line 123: }
Line 124: });
Line 125: getMAC().getPropertyChangedEvent().addListener(this);
....................................................
File
frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java
Line 1824:
Line 1825: @DefaultStringValue("'Port Mirroring' is not supported for
externally-provided networks")
Line 1826: String portMirroringNotSupportedExternalNetworks();
Line 1827:
Line 1828: @DefaultStringValue("Detaching an externally-provided network
from a plugged-in NIC on a running virtual machine is not supported")
Done
Line 1829: String hotNetworkUpdateNotSupportedExternalNetworks();
Line 1830:
Line 1831: @DefaultStringValue("Updating 'Link State' on a running virtual
machine while the NIC is plugged-in is not supported for externally-provided
networks")
Line 1832: String hotLinkStateUpdateNotSupportedExternalNetworks();
--
To view, visit http://gerrit.ovirt.org/15654
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib598d97d76dbfe647a0f71e9269d0a11f68ceaf0
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Lior Vernia <lver...@redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com>
Gerrit-Reviewer: Lior Vernia <lver...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
