Alon Bar-Lev has posted comments on this change.
Change subject: packaging: setup: move log file for db scripts
......................................................................
Patch Set 2: (2 inline comments)
....................................................
File packaging/dbscripts/dbcustomfunctions.sh.in
Line 7: execute_file "insert_predefined_roles.sql" ${DATABASE}
${SERVERNAME} ${PORT} > /dev/null
Line 8: }
Line 9:
Line 10: set_defaults() {
Line 11: . @ENGINE_PROLOG_SH@
engine_prolog should not be used in dbscripts, dbscripts should be more or less
standalone.
Line 12: ME=$(basename $0)
Line 13: SERVERNAME="localhost"
Line 14: PORT="5432"
Line 15: DATABASE="engine"
Line 15: DATABASE="engine"
Line 16: USERNAME="engine"
Line 17: VERBOSE=false
Line 18: TIMESTAMP=$(date +%Y%m%d%H%M%S)
Line 19: LOGFILE="${ENGINE_LOG}/${ME}-${TIMESTAMP}.log"
we should pass explicit parameter of where log file is, and this should be the
log file of the setup so we have all in one file.
Line 20: DBOBJECT_OWNER="engine"
Line 21: NOMD5="false"
Line 22: MD5DIR="$(pwd)"
Line 23: LC_ALL="C"
--
To view, visit http://gerrit.ovirt.org/16381
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia5ca3cbedbe2367843bdf2197b10eac44a6bdc34
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yedidyah Bar David <d...@redhat.com>
Gerrit-Reviewer: Alex Lourie <alou...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Moran Goldboim <mgold...@redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
