Alon Bar-Lev has posted comments on this change.
Change subject: core: i18n welcome page with branding
......................................................................
Patch Set 4: (5 inline comments)
....................................................
File packaging/branding/ovirt.brand/branding.properties
Line 11:
Line 12: # style sheets. (required, but the files can be empty)
Line 13: user_portal_css=user_portal.css
Line 14: web_admin_css=web_admin.css
Line 15: welcome_css=welcome-style.css
use '_' instead of '-' like others?
Line 16:
Line 17: # text (optional, this overrides the default messages)
Line 18: messages=messages.properties
Line 19:
....................................................
File packaging/branding/ovirt.brand/messages.properties
Line 46:
obrand.welcome.section1.row1.url=UserPortal/org.ovirt.engine.ui.userportal.UserPortal/UserPortal.html?locale={0}
Line 47: obrand.welcome.section1.row2.text=Administrator Portal
Line 48:
obrand.welcome.section1.row2.url=webadmin/webadmin/WebAdmin.html?locale={0}
Line 49: obrand.welcome.section1.row3.text=Reports Portal
Line 50:
obrand.welcome.section1.row3.url=OvirtEngineWeb/RedirectServlet?Page=Reports
I still prefer index number similar to ASN-1 and other properties/ini file
arrays.
....................................................
File README.branding
Line 17: resources can be found. Resources are relative to
branding.properties.
Line 18:
Line 19: user_portal_css - Css to inject into user portal (required, can be
empty).
Line 20: web_admin_css - Css to inject into web admin (required, can be
empty).
Line 21: splash_css - Css for the splash page (root) (required, can be
empty).
splash?
Line 22: messages - Standard java message bundle (required).
Line 23: version - The version of the branding in the package. Only versions
Line 24: that match the one defined in the engine will be loaded
(required,
Line 25: theme will not load without it).
Line 35: The oVirt UI is broken up into four distinct modules at this point.
Line 36: * User Portal
Line 37: * Web Admin
Line 38: * Common widgets
Line 39: * splash page (root)
splash?
Line 40:
Line 41: Each of those modules contain some widgets that we can style using CSS
Line 42: clases. Refer to EXAMPLE to see a listing of available classes
categorized
Line 43: by what widget is being styled.
Line 52: 1. branding.properties, This is the main properties file defining
Line 53: the branding properties.
Line 54: 2. user_portal.css, The user portal style sheet file.
Line 55: 3. web_admin.css, The web admin style sheet file.
Line 56: 4. ovirt-engine-style.css, The styles associated with the splash page.
ovirt-engine-style?
Line 57: 5. messages.properties, A java message bundle in many different
locales.
Line 58:
Line 59: Note that images are background images instead of image tags so we can
use
Line 60: style sheets to replace them.
--
To view, visit http://gerrit.ovirt.org/16359
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9987ed58c2e0ead9b25c5f46fb974a96bfd46d30
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alexander Wels <aw...@redhat.com>
Gerrit-Reviewer: Alexander Wels <aw...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Einav Cohen <eco...@redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gsher...@redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
