Yair Zaslavsky has posted comments on this change.

Change subject: [WIP] API: Adding monitored commands to ...
......................................................................


Patch Set 1: (1 inline comment)

....................................................
File 
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendCapabilitiesResource.java
Line 496:         }
Line 497:         return policies;
Line 498:     }
Line 499: 
Line 500:     private MonitoredCommands getMonitoredCommands() {
Ori,
Pardon for the ignorance, but how will the links (for example the link of 
"start" in case of VM resource) help here? shouldn't the links be in context of 
some resource? (for example "start" of VM that it's GUID is <some-guid>) ?
Line 501:         MonitoredCommands commands = new MonitoredCommands();
Line 502:         VdcQueryReturnValue ret = 
runQuery(VdcQueryType.GetMonitoredCommands, new VdcQueryParametersBase());
Line 503:         List<String> list = (ArrayList<String>)ret.getReturnValue();
Line 504:         for (String command : list) {


-- 
To view, visit http://gerrit.ovirt.org/16168
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iaba15e72fa05cd5508139a5fe80567fd95dc7539
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpast...@redhat.com>
Gerrit-Reviewer: Ori Liel <ol...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to