Federico Simoncelli has posted comments on this change.
Change subject: [wip] backend: add glance storage domain support
......................................................................
Patch Set 4: (3 inline comments)
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/StorageType.java
Line 44: return mappings.get(value);
Line 45: }
Line 46:
Line 47: public boolean isFileDomain() {
Line 48: return this == NFS || this == POSIXFS || this == LOCALFS ||
this == GLUSTERFS || this == GLANCE;
Unsure.
Line 49: }
Line 50:
Line 51: public boolean isBlockDomain() {
Line 52: return this == FCP || this == ISCSI;
....................................................
File
backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/businessentities/StorageTypeTest.java
Line 13: Assert.assertTrue(StorageType.NFS.isFileDomain());
Line 14: Assert.assertTrue(StorageType.LOCALFS.isFileDomain());
Line 15: Assert.assertTrue(StorageType.POSIXFS.isFileDomain());
Line 16: Assert.assertTrue(StorageType.GLUSTERFS.isFileDomain());
Line 17: Assert.assertTrue(StorageType.GLANCE.isFileDomain());
Unsure.
Line 18: }
Line 19:
Line 20: @Test
Line 21: public void testIsBlockDomain() {
Line 24: Assert.assertFalse(StorageType.NFS.isBlockDomain());
Line 25: Assert.assertFalse(StorageType.LOCALFS.isBlockDomain());
Line 26: Assert.assertFalse(StorageType.POSIXFS.isBlockDomain());
Line 27: Assert.assertFalse(StorageType.GLUSTERFS.isBlockDomain());
Line 28: Assert.assertFalse(StorageType.GLANCE.isBlockDomain());
Unsure.
Line 29: }
Line 30:
Line 31: @Test
Line 32: public void testNewStorageTypes() {
--
To view, visit http://gerrit.ovirt.org/15897
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3271b3c49907900e37560b63c8ce54d52c463a1e
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimo...@redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
