Re: [PR] Bump mypy-boto3-glue from 1.34.156 to 1.34.157 [iceberg-python]

2024-08-08 Thread via GitHub
Fokko merged PR #1027: URL: https://github.com/apache/iceberg-python/pull/1027 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceber

Re: [PR] Support s3.signer.endpoint for nessie [iceberg-python]

2024-08-08 Thread via GitHub
Fokko commented on code in PR #1029: URL: https://github.com/apache/iceberg-python/pull/1029#discussion_r1710852206 ## pyiceberg/io/fsspec.py: ## @@ -94,7 +100,7 @@ def s3v4_rest_signer(properties: Properties, request: AWSRequest, **_: Any) -> A "headers": {key: [val]

Re: [PR] Support s3.signer.endpoint for nessie [iceberg-python]

2024-08-08 Thread via GitHub
Fokko commented on code in PR #1029: URL: https://github.com/apache/iceberg-python/pull/1029#discussion_r1710850764 ## pyiceberg/io/fsspec.py: ## @@ -86,6 +88,10 @@ def s3v4_rest_signer(properties: Properties, request: AWSRequest, **_: Any) -> A raise SignError("Signer

Re: [PR] Core: Make namespace separator configurable [iceberg]

2024-08-08 Thread via GitHub
nastra commented on code in PR #10877: URL: https://github.com/apache/iceberg/pull/10877#discussion_r1710837520 ## core/src/main/java/org/apache/iceberg/rest/RESTUtil.java: ## @@ -215,8 +232,33 @@ public static String encodeNamespace(Namespace ns) { * @return a namespace

Re: [PR] Core, Flink: Fix build warnings [iceberg]

2024-08-08 Thread via GitHub
nastra commented on code in PR #10899: URL: https://github.com/apache/iceberg/pull/10899#discussion_r1710827750 ## core/src/main/java/org/apache/iceberg/view/BaseViewOperations.java: ## @@ -115,7 +115,7 @@ public void commit(ViewMetadata base, ViewMetadata metadata) { }

Re: [PR] Core, Flink: Fix build warnings [iceberg]

2024-08-08 Thread via GitHub
nastra commented on code in PR #10899: URL: https://github.com/apache/iceberg/pull/10899#discussion_r1710826860 ## core/src/main/java/org/apache/iceberg/view/BaseViewOperations.java: ## @@ -104,7 +104,7 @@ public ViewMetadata refresh() { @Override public void commit(ViewMe

Re: [PR] Core: Make namespace separator configurable [iceberg]

2024-08-08 Thread via GitHub
nastra commented on code in PR #10877: URL: https://github.com/apache/iceberg/pull/10877#discussion_r1710821112 ## core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java: ## @@ -116,6 +116,7 @@ public class RESTSessionCatalog extends BaseViewSessionCatalog privat

Re: [PR] Core: Make namespace separator configurable [iceberg]

2024-08-08 Thread via GitHub
nastra commented on code in PR #10877: URL: https://github.com/apache/iceberg/pull/10877#discussion_r1710818707 ## core/src/test/java/org/apache/iceberg/rest/RESTCatalogAdapter.java: ## @@ -73,6 +73,7 @@ /** Adaptor class to translate REST requests into {@link Catalog} API call

Re: [PR] Core: Make namespace separator configurable [iceberg]

2024-08-08 Thread via GitHub
nastra commented on code in PR #10877: URL: https://github.com/apache/iceberg/pull/10877#discussion_r1710818461 ## core/src/test/java/org/apache/iceberg/rest/RESTCatalogAdapter.java: ## @@ -665,7 +670,7 @@ public static void configureResponseFromException( } private stat

Re: [PR] Core: Make namespace separator configurable [iceberg]

2024-08-08 Thread via GitHub
nastra commented on code in PR #10877: URL: https://github.com/apache/iceberg/pull/10877#discussion_r1710816282 ## core/src/test/java/org/apache/iceberg/rest/TestRESTUtil.java: ## @@ -67,18 +70,24 @@ public void testStripTrailingSlash() { } } - @Test - public void te

Re: [PR] Core: Make namespace separator configurable [iceberg]

2024-08-08 Thread via GitHub
nastra commented on code in PR #10877: URL: https://github.com/apache/iceberg/pull/10877#discussion_r1710802860 ## core/src/main/java/org/apache/iceberg/rest/ResourcePaths.java: ## @@ -40,39 +46,48 @@ public static String tokens() { } private final String prefix; + priv

Re: [PR] Core: Make namespace separator configurable [iceberg]

2024-08-08 Thread via GitHub
nastra commented on code in PR #10877: URL: https://github.com/apache/iceberg/pull/10877#discussion_r1710800461 ## core/src/main/java/org/apache/iceberg/rest/ResourcePaths.java: ## @@ -40,39 +46,48 @@ public static String tokens() { } private final String prefix; + priv

Re: [PR] Core: Make namespace separator configurable [iceberg]

2024-08-08 Thread via GitHub
nastra commented on code in PR #10877: URL: https://github.com/apache/iceberg/pull/10877#discussion_r1710798023 ## core/src/main/java/org/apache/iceberg/rest/RESTUtil.java: ## @@ -215,8 +232,33 @@ public static String encodeNamespace(Namespace ns) { * @return a namespace

Re: [I] Restoring the Flink streaming job from and older checkpoint/savepoint might trigger a silent data loss [iceberg]

2024-08-08 Thread via GitHub
pvary commented on issue #10892: URL: https://github.com/apache/iceberg/issues/10892#issuecomment-2277177813 The main question is whether we think that the Iceberg table state is part of the Flink state, or not. How do other sinks behave with this regard? I have seen requests to he

Re: [I] Restoring the Flink streaming job from and older checkpoint/savepoint might trigger a silent data loss [iceberg]

2024-08-08 Thread via GitHub
stevenzwu commented on issue #10892: URL: https://github.com/apache/iceberg/issues/10892#issuecomment-2277123841 I would also share how I implemented the Flink Iceberg sink at my previous company (Netflix) before the OSS implementation here. We generate UUID for each checkpoint entry/commit

Re: [PR] Spark 3.5: Spark property for avoiding write failures due to missing fields in complex data types [iceberg]

2024-08-08 Thread via GitHub
aleenamg21-1 commented on PR #10361: URL: https://github.com/apache/iceberg/pull/10361#issuecomment-2277076682 @RussellSpitzer Please review this P.R -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] Allow setting `write.parquet.row-group-limit` [iceberg-python]

2024-08-08 Thread via GitHub
zhongyujiang commented on code in PR #1016: URL: https://github.com/apache/iceberg-python/pull/1016#discussion_r1710640916 ## mkdocs/docs/configuration.md: ## @@ -32,6 +32,7 @@ Iceberg tables support table properties to configure table behavior. | -

Re: [I] Restoring the Flink streaming job from the savepoint might trigger a silent data loss when Kafka source is used [iceberg]

2024-08-08 Thread via GitHub
stevenzwu commented on issue #10892: URL: https://github.com/apache/iceberg/issues/10892#issuecomment-2277069747 Let's understand the motivation of `maxCommittedCheckpointId`, it was used to check if there are any unsuccessful commits from restored checkpoint state. But this problem shows a

Re: [I] Restoring the Flink streaming job from the savepoint might trigger a silent data loss when Kafka source is used [iceberg]

2024-08-08 Thread via GitHub
stevenzwu commented on issue #10892: URL: https://github.com/apache/iceberg/issues/10892#issuecomment-2277051765 this is indeed a problem. let's first clarify what should be the expected behavior. When users rewind the job from an older checkpoint/savepoint to reprocess older data, it

Re: [PR] Support s3.signer.endpoint for nessie [iceberg-python]

2024-08-08 Thread via GitHub
ndrluis commented on code in PR #1029: URL: https://github.com/apache/iceberg-python/pull/1029#discussion_r1710534865 ## pyiceberg/io/fsspec.py: ## @@ -86,6 +88,10 @@ def s3v4_rest_signer(properties: Properties, request: AWSRequest, **_: Any) -> A raise SignError("Sign

[PR] Support s3.signer.endpoint for nessie [iceberg-python]

2024-08-08 Thread via GitHub
guitcastro opened a new pull request, #1029: URL: https://github.com/apache/iceberg-python/pull/1029 This PR honor `s3.signer.endpoint` property, fixing the first point in #1028. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

[I] Support for nessie s3 signer [iceberg-python]

2024-08-08 Thread via GitHub
guitcastro opened a new issue, #1028: URL: https://github.com/apache/iceberg-python/issues/1028 ### Apache Iceberg version main (development) ### Please describe the bug 🐞 Nessie s3 signer use a different endpoint than `/aws/s3/sign` and also includes query parameters in

Re: [I] Slowness when loading table from S3 [iceberg-python]

2024-08-08 Thread via GitHub
github-actions[bot] commented on issue #220: URL: https://github.com/apache/iceberg-python/issues/220#issuecomment-2276929391 This issue has been closed because it has not received any activity in the last 14 days since being marked as 'stale' -- This is an automated message from the Apac

Re: [I] Slowness when loading table from S3 [iceberg-python]

2024-08-08 Thread via GitHub
github-actions[bot] closed issue #220: Slowness when loading table from S3 URL: https://github.com/apache/iceberg-python/issues/220 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

Re: [PR] Docs: To delete a table and its underlying data, use the `PURGE` keyword [iceberg]

2024-08-08 Thread via GitHub
github-actions[bot] commented on PR #4746: URL: https://github.com/apache/iceberg/pull/4746#issuecomment-2276927977 This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull

Re: [PR] [wip]: Decouple Hadoop Configuration from FlinkCategoryFactory [iceberg]

2024-08-08 Thread via GitHub
github-actions[bot] commented on PR #4768: URL: https://github.com/apache/iceberg/pull/4768#issuecomment-2276928006 This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull

Re: [PR] Docs: add types supported by truncate [iceberg]

2024-08-08 Thread via GitHub
github-actions[bot] commented on PR #4725: URL: https://github.com/apache/iceberg/pull/4725#issuecomment-2276927914 This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull

Re: [PR] API: Introduce endWiths Predicate. [iceberg]

2024-08-08 Thread via GitHub
github-actions[bot] commented on PR #4721: URL: https://github.com/apache/iceberg/pull/4721#issuecomment-2276927901 This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull

Re: [PR] AWS: Add Cache for LakeFormation Credentials [iceberg]

2024-08-08 Thread via GitHub
github-actions[bot] commented on PR #4695: URL: https://github.com/apache/iceberg/pull/4695#issuecomment-2276927860 This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull

Re: [PR] Docs:Modify the flink version from 0.11.1 to 0.14.4 and fix several errors. [iceberg]

2024-08-08 Thread via GitHub
github-actions[bot] commented on PR #4665: URL: https://github.com/apache/iceberg/pull/4665#issuecomment-2276927819 This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull

Re: [PR] Core: Make snapshot summary return default values [iceberg]

2024-08-08 Thread via GitHub
github-actions[bot] commented on PR #4660: URL: https://github.com/apache/iceberg/pull/4660#issuecomment-2276927790 This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull

Re: [PR] Flink: Support drop non-empty namespace with CASCADE [iceberg]

2024-08-08 Thread via GitHub
github-actions[bot] commented on PR #4658: URL: https://github.com/apache/iceberg/pull/4658#issuecomment-2276927770 This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull

Re: [PR] Make sort strategy an idempotent action [iceberg]

2024-08-08 Thread via GitHub
github-actions[bot] commented on PR #4759: URL: https://github.com/apache/iceberg/pull/4759#issuecomment-2276927992 This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull

Re: [PR] WIP: Improve performance of expire snapshot by not double-scanning non-expired manifests [iceberg]

2024-08-08 Thread via GitHub
github-actions[bot] commented on PR #4736: URL: https://github.com/apache/iceberg/pull/4736#issuecomment-2276927953 This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull

Re: [PR] API: Add default value API [iceberg]

2024-08-08 Thread via GitHub
github-actions[bot] commented on PR #4732: URL: https://github.com/apache/iceberg/pull/4732#issuecomment-2276927935 This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull

Re: [PR] [AWS]Add AwsKmsClient for table encryption KMS client implementation [iceberg]

2024-08-08 Thread via GitHub
github-actions[bot] commented on PR #4714: URL: https://github.com/apache/iceberg/pull/4714#issuecomment-2276927882 This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull

Re: [PR] WIP: Remove redundant sorts from copy on write deletes [iceberg]

2024-08-08 Thread via GitHub
github-actions[bot] commented on PR #4692: URL: https://github.com/apache/iceberg/pull/4692#issuecomment-2276927839 This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull

[PR] Bump mypy-boto3-glue from 1.34.156 to 1.34.157 [iceberg-python]

2024-08-08 Thread via GitHub
dependabot[bot] opened a new pull request, #1027: URL: https://github.com/apache/iceberg-python/pull/1027 Bumps [mypy-boto3-glue](https://github.com/youtype/mypy_boto3_builder) from 1.34.156 to 1.34.157. Commits See full diff in https://github.com/youtype/mypy_boto3_builder/com

Re: [PR] AWS: Implement SupportsRecoveryOperations for S3FileIO [iceberg]

2024-08-08 Thread via GitHub
amogh-jahagirdar commented on code in PR #10721: URL: https://github.com/apache/iceberg/pull/10721#discussion_r1710328535 ## aws/src/main/java/org/apache/iceberg/aws/s3/S3FileIO.java: ## @@ -420,4 +426,46 @@ protected void finalize() throws Throwable { } } } + +

Re: [PR] AWS: Implement SupportsRecoveryOperations for S3FileIO [iceberg]

2024-08-08 Thread via GitHub
amogh-jahagirdar merged PR #10721: URL: https://github.com/apache/iceberg/pull/10721 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@

Re: [PR] Fix: Handle Empty RecordBatch within `_task_to_record_batches` [iceberg-python]

2024-08-08 Thread via GitHub
sungwy commented on code in PR #1026: URL: https://github.com/apache/iceberg-python/pull/1026#discussion_r1710310025 ## pyiceberg/io/pyarrow.py: ## @@ -1249,11 +1251,12 @@ def _task_to_record_batches( # https://github.com/apache/arrow/issues/39220

Re: [I] Table scan throws IndexError: list index out of range [iceberg-python]

2024-08-08 Thread via GitHub
sungwy commented on issue #1024: URL: https://github.com/apache/iceberg-python/issues/1024#issuecomment-2276583048 Hi @vhnguyenae thank you for reporting this issue! I think the fix should be relatively simple. I will work on replicating the issue with a minimum set up to understand at wha

Re: [PR] AWS: Implement SupportsRecoveryOperations for S3FileIO [iceberg]

2024-08-08 Thread via GitHub
singhpk234 commented on code in PR #10721: URL: https://github.com/apache/iceberg/pull/10721#discussion_r1710151755 ## aws/src/main/java/org/apache/iceberg/aws/s3/S3FileIO.java: ## @@ -420,4 +426,46 @@ protected void finalize() throws Throwable { } } } + + @Overr

Re: [PR] REST: AuthManager API [iceberg]

2024-08-08 Thread via GitHub
rdblue commented on code in PR #10753: URL: https://github.com/apache/iceberg/pull/10753#discussion_r1710147069 ## aws/src/main/java/org/apache/iceberg/aws/RESTSigV4AuthManager.java: ## @@ -0,0 +1,51 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or mo

Re: [PR] AWS: Implement SupportsRecoveryOperations for S3FileIO [iceberg]

2024-08-08 Thread via GitHub
amogh-jahagirdar commented on code in PR #10721: URL: https://github.com/apache/iceberg/pull/10721#discussion_r1710093143 ## aws/src/main/java/org/apache/iceberg/aws/s3/S3FileIO.java: ## @@ -420,4 +427,40 @@ protected void finalize() throws Throwable { } } } + +

Re: [PR] Core: V3 Metadata Upgrade Validation and Testing [iceberg]

2024-08-08 Thread via GitHub
leangjonathan commented on code in PR #10861: URL: https://github.com/apache/iceberg/pull/10861#discussion_r1710087155 ## core/src/main/java/org/apache/iceberg/TableMetadata.java: ## @@ -1004,24 +1004,28 @@ private Builder setInitialFormatVersion(int newFormatVersion) {

Re: [PR] Core: V3 Metadata Upgrade Validation and Testing [iceberg]

2024-08-08 Thread via GitHub
leangjonathan commented on code in PR #10861: URL: https://github.com/apache/iceberg/pull/10861#discussion_r1710087155 ## core/src/main/java/org/apache/iceberg/TableMetadata.java: ## @@ -1004,24 +1004,28 @@ private Builder setInitialFormatVersion(int newFormatVersion) {

Re: [PR] AWS: Implement SupportsRecoveryOperations for S3FileIO [iceberg]

2024-08-08 Thread via GitHub
amoghjaha-db commented on code in PR #10721: URL: https://github.com/apache/iceberg/pull/10721#discussion_r1710090471 ## aws/src/main/java/org/apache/iceberg/aws/s3/S3FileIO.java: ## @@ -420,4 +427,40 @@ protected void finalize() throws Throwable { } } } + + @Ove

Re: [PR] Core: V3 Metadata Upgrade Validation and Testing [iceberg]

2024-08-08 Thread via GitHub
leangjonathan commented on code in PR #10861: URL: https://github.com/apache/iceberg/pull/10861#discussion_r1710087155 ## core/src/main/java/org/apache/iceberg/TableMetadata.java: ## @@ -1004,24 +1004,28 @@ private Builder setInitialFormatVersion(int newFormatVersion) {

Re: [I] Restoring the Flink streaming job from the savepoint might trigger a silent data loss when Kafka source is used [iceberg]

2024-08-08 Thread via GitHub
pvary commented on issue #10892: URL: https://github.com/apache/iceberg/issues/10892#issuecomment-2276410555 For the 3rd point: - Flink uses two phase commits. In the 1st phase the data is written to a temp manifest file, and the file path is stored into the state. So if there is a

Re: [PR] AWS: Implement SupportsRecoveryOperations for S3FileIO [iceberg]

2024-08-08 Thread via GitHub
singhpk234 commented on code in PR #10721: URL: https://github.com/apache/iceberg/pull/10721#discussion_r1710037881 ## aws/src/main/java/org/apache/iceberg/aws/s3/S3FileIO.java: ## @@ -420,4 +427,40 @@ protected void finalize() throws Throwable { } } } + + @Overr

Re: [PR] Core: V3 Metadata Upgrade Validation and Testing [iceberg]

2024-08-08 Thread via GitHub
leangjonathan commented on code in PR #10861: URL: https://github.com/apache/iceberg/pull/10861#discussion_r1710037786 ## core/src/main/java/org/apache/iceberg/TableMetadata.java: ## @@ -1020,8 +1020,12 @@ public Builder upgradeFormatVersion(int newFormatVersion) { ret

Re: [PR] Core: V3 Metadata Upgrade Validation and Testing [iceberg]

2024-08-08 Thread via GitHub
leangjonathan commented on code in PR #10861: URL: https://github.com/apache/iceberg/pull/10861#discussion_r1710029012 ## core/src/main/java/org/apache/iceberg/TableMetadata.java: ## @@ -1020,8 +1020,11 @@ public Builder upgradeFormatVersion(int newFormatVersion) { ret

Re: [PR] Fix overwrite when filtering all the data [iceberg-python]

2024-08-08 Thread via GitHub
Fokko commented on code in PR #1023: URL: https://github.com/apache/iceberg-python/pull/1023#discussion_r1710012487 ## tests/integration/test_writes/test_writes.py: ## @@ -1309,3 +1309,27 @@ def test_table_v1_with_null_nested_namespace(session_catalog: Catalog, arrow_tab

Re: [PR] Fix overwrite when filtering all the data [iceberg-python]

2024-08-08 Thread via GitHub
Fokko commented on code in PR #1023: URL: https://github.com/apache/iceberg-python/pull/1023#discussion_r1710012487 ## tests/integration/test_writes/test_writes.py: ## @@ -1309,3 +1309,27 @@ def test_table_v1_with_null_nested_namespace(session_catalog: Catalog, arrow_tab

Re: [PR] Remove deprecated APIs up to 1.7.0 [iceberg]

2024-08-08 Thread via GitHub
findepi commented on PR #10818: URL: https://github.com/apache/iceberg/pull/10818#issuecomment-2276324403 @nk1506 LGTM! @nastra are you planning on taking the final look? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] Fix overwrite when filtering all the data [iceberg-python]

2024-08-08 Thread via GitHub
kevinjqliu commented on code in PR #1023: URL: https://github.com/apache/iceberg-python/pull/1023#discussion_r1709963961 ## tests/integration/test_writes/test_writes.py: ## @@ -1309,3 +1309,27 @@ def test_table_v1_with_null_nested_namespace(session_catalog: Catalog, arrow_tab

Re: [PR] Fix overwrite when filtering all the data [iceberg-python]

2024-08-08 Thread via GitHub
kevinjqliu commented on code in PR #1023: URL: https://github.com/apache/iceberg-python/pull/1023#discussion_r1709963961 ## tests/integration/test_writes/test_writes.py: ## @@ -1309,3 +1309,27 @@ def test_table_v1_with_null_nested_namespace(session_catalog: Catalog, arrow_tab

Re: [PR] AWS: Implement SupportsRecoveryOperations for S3FileIO [iceberg]

2024-08-08 Thread via GitHub
amogh-jahagirdar commented on code in PR #10721: URL: https://github.com/apache/iceberg/pull/10721#discussion_r1709931564 ## aws/src/main/java/org/apache/iceberg/aws/s3/S3FileIO.java: ## @@ -420,4 +427,40 @@ protected void finalize() throws Throwable { } } } + +

Re: [PR] REST: AuthManager API [iceberg]

2024-08-08 Thread via GitHub
rdblue commented on code in PR #10753: URL: https://github.com/apache/iceberg/pull/10753#discussion_r1709934523 ## core/src/main/java/org/apache/iceberg/rest/auth/HttpRequestFacade.java: ## @@ -0,0 +1,76 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * o

Re: [PR] REST: AuthManager API [iceberg]

2024-08-08 Thread via GitHub
rdblue commented on code in PR #10753: URL: https://github.com/apache/iceberg/pull/10753#discussion_r1709933788 ## core/src/main/java/org/apache/iceberg/rest/auth/HttpRequestFacade.java: ## @@ -0,0 +1,76 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * o

Re: [PR] REST: AuthManager API [iceberg]

2024-08-08 Thread via GitHub
rdblue commented on code in PR #10753: URL: https://github.com/apache/iceberg/pull/10753#discussion_r1709931815 ## core/src/main/java/org/apache/iceberg/rest/auth/HttpRequestFacade.java: ## @@ -0,0 +1,76 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * o

Re: [PR] AWS: Implement SupportsRecoveryOperations for S3FileIO [iceberg]

2024-08-08 Thread via GitHub
amogh-jahagirdar commented on code in PR #10721: URL: https://github.com/apache/iceberg/pull/10721#discussion_r1709931564 ## aws/src/main/java/org/apache/iceberg/aws/s3/S3FileIO.java: ## @@ -420,4 +427,40 @@ protected void finalize() throws Throwable { } } } + +

Re: [PR] Fix overwrite when filtering all the data [iceberg-python]

2024-08-08 Thread via GitHub
ndrluis commented on code in PR #1023: URL: https://github.com/apache/iceberg-python/pull/1023#discussion_r1709929378 ## pyiceberg/table/__init__.py: ## @@ -593,7 +593,9 @@ def delete(self, delete_filter: Union[str, BooleanExpression], snapshot_properti filtere

Re: [PR] Fix overwrite when filtering all the data [iceberg-python]

2024-08-08 Thread via GitHub
ndrluis commented on code in PR #1023: URL: https://github.com/apache/iceberg-python/pull/1023#discussion_r1709925255 ## tests/integration/test_writes/test_writes.py: ## @@ -1309,3 +1309,27 @@ def test_table_v1_with_null_nested_namespace(session_catalog: Catalog, arrow_tab

Re: [PR] Core: Make namespace separator configurable [iceberg]

2024-08-08 Thread via GitHub
rdblue commented on code in PR #10877: URL: https://github.com/apache/iceberg/pull/10877#discussion_r1709913592 ## core/src/test/java/org/apache/iceberg/rest/TestRESTUtil.java: ## @@ -67,18 +70,24 @@ public void testStripTrailingSlash() { } } - @Test - public void te

Re: [I] Using pyiceberg HiveCatalog to connect to hive4 [iceberg-python]

2024-08-08 Thread via GitHub
rni-HMC commented on issue #1019: URL: https://github.com/apache/iceberg-python/issues/1019#issuecomment-2276254815 Awesome, thanks so much for your help! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [I] Using pyiceberg HiveCatalog to connect to hive4 [iceberg-python]

2024-08-08 Thread via GitHub
rni-HMC closed issue #1019: Using pyiceberg HiveCatalog to connect to hive4 URL: https://github.com/apache/iceberg-python/issues/1019 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

Re: [I] Using pyiceberg HiveCatalog to connect to hive4 [iceberg]

2024-08-08 Thread via GitHub
rni-HMC commented on issue #10903: URL: https://github.com/apache/iceberg/issues/10903#issuecomment-2276255831 Closed - see comments in https://github.com/apache/iceberg-python/issues/1019 -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [I] Using pyiceberg HiveCatalog to connect to hive4 [iceberg]

2024-08-08 Thread via GitHub
rni-HMC closed issue #10903: Using pyiceberg HiveCatalog to connect to hive4 URL: https://github.com/apache/iceberg/issues/10903 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] Core: Make namespace separator configurable [iceberg]

2024-08-08 Thread via GitHub
rdblue commented on code in PR #10877: URL: https://github.com/apache/iceberg/pull/10877#discussion_r1709908764 ## core/src/test/java/org/apache/iceberg/rest/RESTCatalogAdapter.java: ## @@ -665,7 +670,7 @@ public static void configureResponseFromException( } private stat

Re: [PR] Core: Make namespace separator configurable [iceberg]

2024-08-08 Thread via GitHub
rdblue commented on code in PR #10877: URL: https://github.com/apache/iceberg/pull/10877#discussion_r1709907532 ## core/src/test/java/org/apache/iceberg/rest/RESTCatalogAdapter.java: ## @@ -73,6 +73,7 @@ /** Adaptor class to translate REST requests into {@link Catalog} API call

Re: [PR] Core: Make namespace separator configurable [iceberg]

2024-08-08 Thread via GitHub
rdblue commented on code in PR #10877: URL: https://github.com/apache/iceberg/pull/10877#discussion_r1709904764 ## core/src/main/java/org/apache/iceberg/rest/ResourcePaths.java: ## @@ -40,39 +46,48 @@ public static String tokens() { } private final String prefix; + priv

Re: [PR] Core: Make namespace separator configurable [iceberg]

2024-08-08 Thread via GitHub
rdblue commented on code in PR #10877: URL: https://github.com/apache/iceberg/pull/10877#discussion_r1709903381 ## core/src/main/java/org/apache/iceberg/rest/ResourcePaths.java: ## @@ -40,39 +46,48 @@ public static String tokens() { } private final String prefix; + priv

Re: [I] Table scan throws IndexError: list index out of range [iceberg-python]

2024-08-08 Thread via GitHub
kevinjqliu commented on issue #1024: URL: https://github.com/apache/iceberg-python/issues/1024#issuecomment-2276208972 Interesting... the error is in `_task_to_record_batches` https://github.com/apache/iceberg-python/blob/eca98707f30bdaf1ffd19f039058cc7e18c5f9cb/pyiceberg/io/pyarrow.py#L

Re: [PR] Core: Make namespace separator configurable [iceberg]

2024-08-08 Thread via GitHub
rdblue commented on code in PR #10877: URL: https://github.com/apache/iceberg/pull/10877#discussion_r1709887786 ## core/src/main/java/org/apache/iceberg/rest/RESTUtil.java: ## @@ -215,8 +232,33 @@ public static String encodeNamespace(Namespace ns) { * @return a namespace

Re: [PR] Core: Make namespace separator configurable [iceberg]

2024-08-08 Thread via GitHub
rdblue commented on code in PR #10877: URL: https://github.com/apache/iceberg/pull/10877#discussion_r1709885848 ## core/src/main/java/org/apache/iceberg/rest/RESTUtil.java: ## @@ -215,8 +232,33 @@ public static String encodeNamespace(Namespace ns) { * @return a namespace

Re: [PR] Core: Make namespace separator configurable [iceberg]

2024-08-08 Thread via GitHub
rdblue commented on code in PR #10877: URL: https://github.com/apache/iceberg/pull/10877#discussion_r1709883660 ## core/src/main/java/org/apache/iceberg/rest/RESTUtil.java: ## @@ -194,15 +192,34 @@ public static String decodeString(String encoded) { * @return UTF-8 encoded s

Re: [PR] Core: Make namespace separator configurable [iceberg]

2024-08-08 Thread via GitHub
rdblue commented on code in PR #10877: URL: https://github.com/apache/iceberg/pull/10877#discussion_r1709881402 ## core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java: ## @@ -116,6 +116,7 @@ public class RESTSessionCatalog extends BaseViewSessionCatalog privat

Re: [I] Create AWS Glue table from table JSON [iceberg-python]

2024-08-08 Thread via GitHub
kevinjqliu commented on issue #1025: URL: https://github.com/apache/iceberg-python/issues/1025#issuecomment-2276218470 You can certainly create a Python function to translate from the JSON to Iceberg Schema. You might need to hard code some type mapping though. For example, there's no `big

Re: [PR] OpenAPI: Add query param to control namespace separator [iceberg]

2024-08-08 Thread via GitHub
dimas-b commented on code in PR #10904: URL: https://github.com/apache/iceberg/pull/10904#discussion_r1709804497 ## open-api/rest-catalog-open-api.yaml: ## @@ -217,12 +217,14 @@ paths: parameters: - $ref: '#/components/parameters/page-token' - $ref: '#/c

Re: [PR] AWS: Implement SupportsRecoveryOperations for S3FileIO [iceberg]

2024-08-08 Thread via GitHub
danielcweeks commented on code in PR #10721: URL: https://github.com/apache/iceberg/pull/10721#discussion_r1709801097 ## aws/src/main/java/org/apache/iceberg/aws/s3/S3FileIO.java: ## @@ -420,4 +427,40 @@ protected void finalize() throws Throwable { } } } + + @Ove

Re: [PR] fix: complete miss attribute for map && list in avro schema [iceberg-rust]

2024-08-08 Thread via GitHub
Fokko merged PR #411: URL: https://github.com/apache/iceberg-rust/pull/411 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.ap

Re: [PR] AWS: Implement SupportsRecoveryOperations for S3FileIO [iceberg]

2024-08-08 Thread via GitHub
danielcweeks commented on code in PR #10721: URL: https://github.com/apache/iceberg/pull/10721#discussion_r1709774374 ## aws/src/main/java/org/apache/iceberg/aws/s3/S3FileIO.java: ## @@ -420,4 +427,40 @@ protected void finalize() throws Throwable { } } } + + @Ove

Re: [PR] #10668 - Support case-insensitivity for column names in PartitionSpec [iceberg]

2024-08-08 Thread via GitHub
nastra commented on code in PR #10678: URL: https://github.com/apache/iceberg/pull/10678#discussion_r1709778268 ## core/src/test/java/org/apache/iceberg/TestPartitionSpecInfo.java: ## @@ -20,6 +20,7 @@ import static org.apache.iceberg.types.Types.NestedField.required; import

Re: [PR] Fix overwrite when filtering all the data [iceberg-python]

2024-08-08 Thread via GitHub
kevinjqliu commented on code in PR #1023: URL: https://github.com/apache/iceberg-python/pull/1023#discussion_r1709774974 ## pyiceberg/table/__init__.py: ## @@ -593,7 +593,9 @@ def delete(self, delete_filter: Union[str, BooleanExpression], snapshot_properti filt

Re: [PR] AWS: Implement SupportsRecoveryOperations for S3FileIO [iceberg]

2024-08-08 Thread via GitHub
danielcweeks commented on code in PR #10721: URL: https://github.com/apache/iceberg/pull/10721#discussion_r1709774374 ## aws/src/main/java/org/apache/iceberg/aws/s3/S3FileIO.java: ## @@ -420,4 +427,40 @@ protected void finalize() throws Throwable { } } } + + @Ove

Re: [PR] fix: complete miss attribute for map && list in avro schema [iceberg-rust]

2024-08-08 Thread via GitHub
Fokko commented on code in PR #411: URL: https://github.com/apache/iceberg-rust/pull/411#discussion_r1709773813 ## crates/iceberg/src/avro/schema.rs: ## @@ -826,7 +914,117 @@ mod tests { .unwrap() }; -check_schema_conversion(avro_schema, icebe

Re: [PR] AWS: Implement SupportsRecoveryOperations for S3FileIO [iceberg]

2024-08-08 Thread via GitHub
danielcweeks commented on code in PR #10721: URL: https://github.com/apache/iceberg/pull/10721#discussion_r1709765272 ## aws/src/main/java/org/apache/iceberg/aws/s3/S3FileIO.java: ## @@ -420,4 +427,40 @@ protected void finalize() throws Throwable { } } } + + @Ove

Re: [PR] fix: complete miss attribute for map && list in avro schema [iceberg-rust]

2024-08-08 Thread via GitHub
ZENOTME commented on code in PR #411: URL: https://github.com/apache/iceberg-rust/pull/411#discussion_r1709758856 ## crates/iceberg/src/avro/schema.rs: ## @@ -557,22 +649,19 @@ mod tests { AvroSchema::parse_str(input.as_str()).unwrap() } -fn check_schema_conv

Re: [PR] Core: Pass namespace separator via query param [iceberg]

2024-08-08 Thread via GitHub
nastra commented on code in PR #10905: URL: https://github.com/apache/iceberg/pull/10905#discussion_r1709732604 ## core/src/test/java/org/apache/iceberg/rest/RESTCatalogAdapter.java: ## @@ -670,7 +681,9 @@ public static void configureResponseFromException( } private stat

Re: [PR] Core: Pass namespace separator via query param [iceberg]

2024-08-08 Thread via GitHub
dimas-b commented on code in PR #10905: URL: https://github.com/apache/iceberg/pull/10905#discussion_r1709724932 ## core/src/test/java/org/apache/iceberg/rest/RESTCatalogAdapter.java: ## @@ -670,7 +681,9 @@ public static void configureResponseFromException( } private sta

Re: [PR] Core: Make namespace separator configurable [iceberg]

2024-08-08 Thread via GitHub
dimas-b commented on code in PR #10877: URL: https://github.com/apache/iceberg/pull/10877#discussion_r1709702079 ## open-api/rest-catalog-open-api.yaml: ## @@ -222,7 +222,10 @@ paths: description: An optional namespace, underneath which to list namespaces

Re: [PR] Deprecate Redundant Identifier Support in TableIdentifier, and row_filter [iceberg-python]

2024-08-08 Thread via GitHub
sungwy commented on PR #994: URL: https://github.com/apache/iceberg-python/pull/994#issuecomment-2276038211 Merged! 🙌 Thank you for the reviews @ndrluis @kevinjqliu and @Fokko ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] Deprecate Redundant Identifier Support in TableIdentifier, and row_filter [iceberg-python]

2024-08-08 Thread via GitHub
sungwy merged PR #994: URL: https://github.com/apache/iceberg-python/pull/994 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg

Re: [PR] Core: Make namespace separator configurable [iceberg]

2024-08-08 Thread via GitHub
nastra commented on code in PR #10877: URL: https://github.com/apache/iceberg/pull/10877#discussion_r1709694414 ## open-api/rest-catalog-open-api.yaml: ## @@ -222,7 +222,10 @@ paths: description: An optional namespace, underneath which to list namespaces.

Re: [PR] Core: Make namespace separator configurable [iceberg]

2024-08-08 Thread via GitHub
dimas-b commented on code in PR #10877: URL: https://github.com/apache/iceberg/pull/10877#discussion_r1709690499 ## open-api/rest-catalog-open-api.yaml: ## @@ -222,7 +222,10 @@ paths: description: An optional namespace, underneath which to list namespaces

Re: [PR] Core: Make namespace separator configurable [iceberg]

2024-08-08 Thread via GitHub
nastra commented on code in PR #10877: URL: https://github.com/apache/iceberg/pull/10877#discussion_r1709688072 ## open-api/rest-catalog-open-api.yaml: ## @@ -222,7 +222,10 @@ paths: description: An optional namespace, underneath which to list namespaces.

Re: [PR] Core: Make namespace separator configurable [iceberg]

2024-08-08 Thread via GitHub
dimas-b commented on code in PR #10877: URL: https://github.com/apache/iceberg/pull/10877#discussion_r1709686056 ## open-api/rest-catalog-open-api.yaml: ## @@ -222,7 +222,10 @@ paths: description: An optional namespace, underneath which to list namespaces

Re: [PR] Core: Make namespace separator configurable [iceberg]

2024-08-08 Thread via GitHub
dimas-b commented on code in PR #10877: URL: https://github.com/apache/iceberg/pull/10877#discussion_r1709686056 ## open-api/rest-catalog-open-api.yaml: ## @@ -222,7 +222,10 @@ paths: description: An optional namespace, underneath which to list namespaces

  1   2   >