nastra commented on code in PR #10678: URL: https://github.com/apache/iceberg/pull/10678#discussion_r1709778268
########## core/src/test/java/org/apache/iceberg/TestPartitionSpecInfo.java: ########## @@ -20,6 +20,7 @@ import static org.apache.iceberg.types.Types.NestedField.required; import static org.assertj.core.api.Assertions.assertThat; +import static org.assertj.core.api.Assertions.assertThatIllegalArgumentException; Review Comment: during the JUni4 -> JUnit5 migration we used static imports of `assertThat` for better readability at places that didn't use AssertJ assertions before and switched from JUnit4 asserts to AssertJ asserts. At that point the codebase was split between static import usage of `assertThat` and non-static usage and so we eventually enforced static imports for AssertJ assertions via https://github.com/apache/iceberg/pull/10517 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
