ndrluis commented on code in PR #1029:
URL: https://github.com/apache/iceberg-python/pull/1029#discussion_r1710534865
##########
pyiceberg/io/fsspec.py:
##########
@@ -86,6 +88,10 @@ def s3v4_rest_signer(properties: Properties, request:
AWSRequest, **_: Any) -> A
raise SignError("Signer set, but token is not available")
signer_url = properties.get(S3_SIGNER_URI, properties["uri"]).rstrip("/")
+ signer_endpoint = properties.get(S3_SIGNER_ENDPOINT, None)
+ if signer_endpoint is None:
+ signer_endpoint = properties.get("endpoint",
S3_SIGNER_ENDPOINT_DEFAULT_VALUE)
Review Comment:
I'm not sure if I understand what this "endpoint" property key is. Is there
any reason why it shouldn't be something like this: `signer_endpoint =
properties.get(S3_SIGNER_ENDPOINT, S3_SIGNER_ENDPOINT_DEFAULT_VALUE)`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
