nastra commented on code in PR #10877:
URL: https://github.com/apache/iceberg/pull/10877#discussion_r1710818461
##########
core/src/test/java/org/apache/iceberg/rest/RESTCatalogAdapter.java:
##########
@@ -665,7 +670,7 @@ public static void configureResponseFromException(
}
private static Namespace namespaceFromPathVars(Map<String, String> pathVars)
{
- return RESTUtil.decodeNamespace(pathVars.get("namespace"));
+ return RESTUtil.decodeNamespace(pathVars.get("namespace"),
NAMESPACE_SEPARATOR);
Review Comment:
yes and that is being handled in
https://github.com/apache/iceberg/pull/10905. However, as a first step we need
to make the namespace separator configurable (regardless of whether it's
configurable from the server or the client), which is being handled in this PR.
Making it controllable from the client and send a query param is handled after
this PR in https://github.com/apache/iceberg/pull/10905 (and requires a vote on
the [spec change](https://github.com/apache/iceberg/pull/10904))
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
