Fokko commented on code in PR #1023:
URL: https://github.com/apache/iceberg-python/pull/1023#discussion_r1710012487
##########
tests/integration/test_writes/test_writes.py:
##########
@@ -1309,3 +1309,27 @@ def
test_table_v1_with_null_nested_namespace(session_catalog: Catalog, arrow_tab
# We expect no error here
session_catalog.drop_table(identifier)
+
+
+@pytest.mark.integration
+def test_overwrite_all_data_with_filter(session_catalog: Catalog) -> None:
+ schema = Schema(
+ NestedField(1, "id", StringType(), required=True),
+ NestedField(2, "name", StringType(), required=False),
+ identifier_field_ids=[1],
+ )
+
+ data = pa.Table.from_pylist(
+ [
+ {"id": "1", "name": "Amsterdam"},
+ {"id": "2", "name": "San Francisco"},
+ {"id": "3", "name": "Drachten"},
+ ],
+ schema=schema.as_arrow(),
+ )
+
+ identifier = "default.test_overwrite_all_data_with_filter"
+ tbl = _create_table(session_catalog, identifier, data=[data],
schema=schema)
+ tbl.overwrite(data, In("id", ["1", "2", "3"]))
+
+ assert len(tbl.scan().to_arrow()) == 3
Review Comment:
Yes exactly. One thing to note is that it would be even more correct to add
this to a `DELETE` snapshot, it is not replaced, but just dropped. Please note
that most engines just use `OVERWRITE`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
