nastra commented on code in PR #10877:
URL: https://github.com/apache/iceberg/pull/10877#discussion_r1710816282
##########
core/src/test/java/org/apache/iceberg/rest/TestRESTUtil.java:
##########
@@ -67,18 +70,24 @@ public void testStripTrailingSlash() {
}
}
- @Test
- public void testRoundTripUrlEncodeDecodeNamespace() {
+ @ParameterizedTest
+ @ValueSource(strings = {"%1F", "%2D", "%2E"})
Review Comment:
yes, but the test also uses the non-UTF-8 strings within the namespace, so
we need to use the UTF-8 encoded string. I've added some non-UTF-8 encoded
strings to the parameters list to indicate that such strings can be used as
well (as long as they aren't allowed in the namespace name itself)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
