Fokko commented on code in PR #1029:
URL: https://github.com/apache/iceberg-python/pull/1029#discussion_r1710852206
##########
pyiceberg/io/fsspec.py:
##########
@@ -94,7 +100,7 @@ def s3v4_rest_signer(properties: Properties, request:
AWSRequest, **_: Any) -> A
"headers": {key: [val] for key, val in request.headers.items()},
}
- response = requests.post(f"{signer_url}/v1/aws/s3/sign",
headers=signer_headers, json=signer_body)
+ response = requests.post(f"{signer_url}/{signer_endpoint.lstrip()}",
headers=signer_headers, json=signer_body)
Review Comment:
If we want to clean up the property, why not also prune any trailing
whitespace?
```suggestion
response = requests.post(f"{signer_url}/{signer_endpoint.strip()}",
headers=signer_headers, json=signer_body)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
