Fokko commented on code in PR #411:
URL: https://github.com/apache/iceberg-rust/pull/411#discussion_r1709773813


##########
crates/iceberg/src/avro/schema.rs:
##########
@@ -826,7 +914,117 @@ mod tests {
                 .unwrap()
         };
 
-        check_schema_conversion(avro_schema, iceberg_schema, false);
+        check_schema_conversion(avro_schema, iceberg_schema);
+    }
+
+    #[test]
+    fn test_schema_with_array_map() {
+        let avro_schema = {
+            AvroSchema::parse_str(
+                r#"
+{
+    "type": "record",
+    "name": "avro_schema",
+    "fields": [
+        {
+            "name": "optional",
+            "type": {

Review Comment:
   Ah, it is actually here: 
https://github.com/apache/iceberg-rust/pull/411/files#diff-542e38433ab477bbc8669524448ecf923f3f0b12c52d725984d1d160e536656eR958
   Sorry for the confusion 👍 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to