zhongyujiang commented on code in PR #1016:
URL: https://github.com/apache/iceberg-python/pull/1016#discussion_r1710640916


##########
mkdocs/docs/configuration.md:
##########
@@ -32,6 +32,7 @@ Iceberg tables support table properties to configure table 
behavior.
 | -------------------------------------- | --------------------------------- | 
------- | 
-------------------------------------------------------------------------------------------
 |
 | `write.parquet.compression-codec`      | `{uncompressed,zstd,gzip,snappy}` | 
zstd    | Sets the Parquet compression coddec.                                  
                      |
 | `write.parquet.compression-level`      | Integer                           | 
null    | Parquet compression level for the codec. If not set, it is up to 
PyIceberg                  |
+| `write.parquet.row-group-limit`        | Number of rows                    | 
1048576 | The upper bound of the number of entries within a single row group    
                      |

Review Comment:
   @Fokko @sungwy Thanks, I believe this has resolved my issue #1012 as well. 
   
   However, I would like to remind you that this option already exists in the 
doc, right after `write.parquet.dict-size-bytes`, the UI doesn't allow me to 
leave a comment there, so please expand the collapsed area to see it.
   
   Additionally, I'm kind of curious as to why the default value used this time 
is significantly larger than the previous one?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to