danielcweeks commented on code in PR #10721:
URL: https://github.com/apache/iceberg/pull/10721#discussion_r1709801097
##########
aws/src/main/java/org/apache/iceberg/aws/s3/S3FileIO.java:
##########
@@ -420,4 +427,40 @@ protected void finalize() throws Throwable {
}
}
}
+
+ @Override
+ public boolean recoverFile(String path) {
+ S3URI location = new S3URI(path,
s3FileIOProperties.bucketToAccessPointMapping());
+ ListObjectVersionsIterable response =
+ client()
+ .listObjectVersionsPaginator(
+ ListObjectVersionsRequest.builder()
+ .bucket(location.bucket())
+ .prefix(location.key())
+ .build());
+
+ Optional<ObjectVersion> latestVersion =
+
response.versions().stream().max(Comparator.comparing(ObjectVersion::lastModified));
+ return latestVersion.map(version -> recoverObject(version,
location.bucket())).orElse(false);
Review Comment:
You might want to put a check here for `version.isLatest()` just to protect
against being called on an object this the latest version. It's unlikely, but
it could actually recover and older version since there is no direct check here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
