rdblue commented on code in PR #10877:
URL: https://github.com/apache/iceberg/pull/10877#discussion_r1709904764
##########
core/src/main/java/org/apache/iceberg/rest/ResourcePaths.java:
##########
@@ -40,39 +46,48 @@ public static String tokens() {
}
private final String prefix;
+ private final String namespaceSeparator;
public ResourcePaths(String prefix) {
+ this(prefix, RESTUtil.NAMESPACE_ESCAPED_SEPARATOR);
+ }
+
+ private ResourcePaths(String prefix, String namespaceSeparator) {
this.prefix = prefix;
+ this.namespaceSeparator = namespaceSeparator;
}
public String namespaces() {
return SLASH.join("v1", prefix, "namespaces");
}
public String namespace(Namespace ns) {
- return SLASH.join("v1", prefix, "namespaces",
RESTUtil.encodeNamespace(ns));
+ return SLASH.join("v1", prefix, "namespaces", RESTUtil.encodeNamespace(ns,
namespaceSeparator));
Review Comment:
Nit: I think it would be cleaner to add a method like `pathEncode` that
applies the separator. Embedding this everywhere is causing lines to get too
long.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
