ndrluis commented on code in PR #1023:
URL: https://github.com/apache/iceberg-python/pull/1023#discussion_r1709929378
##########
pyiceberg/table/__init__.py:
##########
@@ -593,7 +593,9 @@ def delete(self, delete_filter: Union[str,
BooleanExpression], snapshot_properti
filtered_df = df.filter(preserve_row_filter)
# Only rewrite if there are records being deleted
- if len(df) != len(filtered_df):
+ if len(filtered_df) == 0:
+ replaced_files.append((original_file.file, []))
+ elif len(df) != len(filtered_df):
Review Comment:
To be honest, I don't see much of a difference.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
