singhpk234 commented on code in PR #10721:
URL: https://github.com/apache/iceberg/pull/10721#discussion_r1710151755
##########
aws/src/main/java/org/apache/iceberg/aws/s3/S3FileIO.java:
##########
@@ -420,4 +426,46 @@ protected void finalize() throws Throwable {
}
}
}
+
+ @Override
+ public boolean recoverFile(String path) {
+ S3URI location = new S3URI(path,
s3FileIOProperties.bucketToAccessPointMapping());
+ ListObjectVersionsIterable response =
+ client()
+ .listObjectVersionsPaginator(
+ builder ->
builder.bucket(location.bucket()).prefix(location.key()));
+
+ // Recover to the last modified version, not isLatest,
+ // since isLatest is true for deletion markers.
+ Optional<ObjectVersion> recoverVersion =
+
response.versions().stream().max(Comparator.comparing(ObjectVersion::lastModified));
+
+ return recoverVersion.map(version -> recoverObject(version,
location.bucket())).orElse(false);
+ }
+
+ private boolean recoverObject(ObjectVersion version, String bucket) {
+ if (version.isLatest()) {
+ return true;
+ }
Review Comment:
[optional] we can have an integ test trying to restore an existing object
doesn't leads to creating a new version of obj
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
