Re: [PR] fix #9269 Switch class level parameterized for mr [iceberg]

2024-02-12 Thread via GitHub
lisirrx commented on code in PR #9711: URL: https://github.com/apache/iceberg/pull/9711#discussion_r1487359273 ## mr/src/test/java/org/apache/iceberg/mr/TestIcebergInputFormats.java: ## @@ -90,52 +93,49 @@ public class TestIcebergInputFormats { private static final PartitionS

Re: [PR] feat(catalog): add initial rest catalog impl [iceberg-go]

2024-02-12 Thread via GitHub
nastra commented on code in PR #58: URL: https://github.com/apache/iceberg-go/pull/58#discussion_r1487349698 ## catalog/catalog.go: ## @@ -47,19 +52,136 @@ func WithAwsConfig(cfg aws.Config) Option { } } +func WithCredential(cred string) Option { + return func(o

Re: [PR] feat(catalog): add initial rest catalog impl [iceberg-go]

2024-02-12 Thread via GitHub
nastra commented on code in PR #58: URL: https://github.com/apache/iceberg-go/pull/58#discussion_r1487326967 ## cmd/iceberg/main.go: ## @@ -0,0 +1,332 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE fi

Re: [PR] feat(catalog): add initial rest catalog impl [iceberg-go]

2024-02-12 Thread via GitHub
nastra commented on code in PR #58: URL: https://github.com/apache/iceberg-go/pull/58#discussion_r1487323964 ## dev/Dockerfile: ## @@ -0,0 +1,66 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more Review Comment: ah I missed that. In that case we should

Re: [PR] [WIP] Migrate Write sub-classes in spark-extensions to JUnit5 and AssertJ style [iceberg]

2024-02-12 Thread via GitHub
nastra commented on code in PR #9670: URL: https://github.com/apache/iceberg/pull/9670#discussion_r1487320357 ## spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestUpdate.java: ## @@ -288,34 +265,34 @@ public void testExplain() { sql("EXPLAIN

Re: [PR] [WIP] Migrate Write sub-classes in spark-extensions to JUnit5 and AssertJ style [iceberg]

2024-02-12 Thread via GitHub
nastra commented on code in PR #9670: URL: https://github.com/apache/iceberg/pull/9670#discussion_r1487317862 ## spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestDelete.java: ## @@ -1296,40 +1282,36 @@ public void testDeleteToWapBranch() throws

Re: [PR] [WIP] Migrate Write sub-classes in spark-extensions to JUnit5 and AssertJ style [iceberg]

2024-02-12 Thread via GitHub
nastra commented on code in PR #9670: URL: https://github.com/apache/iceberg/pull/9670#discussion_r1487317411 ## spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestDelete.java: ## @@ -1282,9 +1266,11 @@ public void testDeleteWithMultipleSpecs() {

Re: [PR] [WIP] Migrate Write sub-classes in spark-extensions to JUnit5 and AssertJ style [iceberg]

2024-02-12 Thread via GitHub
nastra commented on code in PR #9670: URL: https://github.com/apache/iceberg/pull/9670#discussion_r1487315985 ## spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestDelete.java: ## @@ -884,9 +867,9 @@ public void testDeleteWithNotInSubquery() throws

Re: [PR] [WIP] Migrate Write sub-classes in spark-extensions to JUnit5 and AssertJ style [iceberg]

2024-02-12 Thread via GitHub
nastra commented on code in PR #9670: URL: https://github.com/apache/iceberg/pull/9670#discussion_r1487316766 ## spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestDelete.java: ## @@ -1015,20 +998,21 @@ public void testDeleteThatRequiresGroupingBef

Re: [PR] [WIP] Migrate Write sub-classes in spark-extensions to JUnit5 and AssertJ style [iceberg]

2024-02-12 Thread via GitHub
nastra commented on code in PR #9670: URL: https://github.com/apache/iceberg/pull/9670#discussion_r1487315629 ## spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestDelete.java: ## @@ -709,9 +692,9 @@ public void testDeleteWithInAndNotInConditions()

Re: [PR] [WIP] Migrate Write sub-classes in spark-extensions to JUnit5 and AssertJ style [iceberg]

2024-02-12 Thread via GitHub
nastra commented on code in PR #9670: URL: https://github.com/apache/iceberg/pull/9670#discussion_r1487314491 ## spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestDelete.java: ## @@ -390,42 +373,42 @@ public void testDeleteWithFalseCondition() {

Re: [PR] [WIP] Migrate Write sub-classes in spark-extensions to JUnit5 and AssertJ style [iceberg]

2024-02-12 Thread via GitHub
tomtongue commented on code in PR #9670: URL: https://github.com/apache/iceberg/pull/9670#discussion_r1487313598 ## spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/SparkRowLevelOperationsTestBase.java: ## @@ -69,41 +72,30 @@ import org.apache.spark

Re: [PR] [WIP] Migrate Write sub-classes in spark-extensions to JUnit5 and AssertJ style [iceberg]

2024-02-12 Thread via GitHub
nastra commented on code in PR #9670: URL: https://github.com/apache/iceberg/pull/9670#discussion_r1487313497 ## spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestDelete.java: ## @@ -339,16 +321,17 @@ public void testDeleteFileThenMetadataDelete()

Re: [PR] [WIP] Migrate Write sub-classes in spark-extensions to JUnit5 and AssertJ style [iceberg]

2024-02-12 Thread via GitHub
nastra commented on code in PR #9670: URL: https://github.com/apache/iceberg/pull/9670#discussion_r1487312284 ## spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestDelete.java: ## @@ -322,9 +302,11 @@ public void testDeleteWithoutScanningTable() th

Re: [PR] [WIP] Migrate Write sub-classes in spark-extensions to JUnit5 and AssertJ style [iceberg]

2024-02-12 Thread via GitHub
nastra commented on code in PR #9670: URL: https://github.com/apache/iceberg/pull/9670#discussion_r1487305715 ## spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/SparkRowLevelOperationsTestBase.java: ## @@ -69,41 +72,30 @@ import org.apache.spark.sq

Re: [I] InMemoryCatalog's FiloIO in memory map isn't persistent in RestCatalog [iceberg]

2024-02-12 Thread via GitHub
nastra commented on issue #9604: URL: https://github.com/apache/iceberg/issues/9604#issuecomment-1940527159 +1 to fixing the behavior in `TestRESTCatalog` when using `InMemoryCatalog` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

Re: [PR] Spec: Clarify multi-arg transform behavior for different versions [iceberg]

2024-02-12 Thread via GitHub
szehon-ho commented on code in PR #9661: URL: https://github.com/apache/iceberg/pull/9661#discussion_r1487243929 ## format/spec.md: ## @@ -1130,14 +1142,10 @@ Each partition field in the fields list is stored as an object. See the table fo |**`hour`**|`JSON string: "hour"`|`"h

Re: [PR] Spec: Clarify multi-arg transform behavior for different versions [iceberg]

2024-02-12 Thread via GitHub
szehon-ho commented on code in PR #9661: URL: https://github.com/apache/iceberg/pull/9661#discussion_r1487243929 ## format/spec.md: ## @@ -1130,14 +1142,10 @@ Each partition field in the fields list is stored as an object. See the table fo |**`hour`**|`JSON string: "hour"`|`"h

Re: [PR] Spec: Clarify multi-arg transform behavior for different versions [iceberg]

2024-02-12 Thread via GitHub
szehon-ho commented on code in PR #9661: URL: https://github.com/apache/iceberg/pull/9661#discussion_r1487244304 ## format/spec.md: ## @@ -1314,6 +1324,25 @@ Default values are added to struct fields in v3. Types `timestamp_ns` and `timestamptz_ns` are added in v3. +Sort or

Re: [PR] Spec: Clarify multi-arg transform behavior for different versions [iceberg]

2024-02-12 Thread via GitHub
szehon-ho commented on code in PR #9661: URL: https://github.com/apache/iceberg/pull/9661#discussion_r1487243929 ## format/spec.md: ## @@ -1130,14 +1142,10 @@ Each partition field in the fields list is stored as an object. See the table fo |**`hour`**|`JSON string: "hour"`|`"h

Re: [PR] OpenAPI: Add AppendDataFileUpdate to TableUpdate for rest appends [iceberg]

2024-02-12 Thread via GitHub
rahil-c commented on code in PR #9717: URL: https://github.com/apache/iceberg/pull/9717#discussion_r1487236228 ## open-api/rest-catalog-open-api.yaml: ## @@ -3324,6 +3348,97 @@ components: type: integer format: int64 +TypeValue: + oneOf: +

Re: [PR] Spec: Clarify multi-arg transform behavior for different versions [iceberg]

2024-02-12 Thread via GitHub
szehon-ho commented on code in PR #9661: URL: https://github.com/apache/iceberg/pull/9661#discussion_r1487234117 ## format/spec.md: ## @@ -1117,7 +1119,17 @@ Partition specs are serialized as a JSON object with the following fields: |**`spec-id`**|`JSON int`|`0`| |**`fields`*

Re: [PR] Spec: Clarify multi-arg transform behavior for different versions [iceberg]

2024-02-12 Thread via GitHub
szehon-ho commented on code in PR #9661: URL: https://github.com/apache/iceberg/pull/9661#discussion_r1487233897 ## format/spec.md: ## @@ -301,7 +301,7 @@ Tables are configured with a **partition spec** that defines how to produce a tu * A **transform** that is applied to th

Re: [PR] OpenAPI: Add AppendDataFileUpdate to TableUpdate for rest appends [iceberg]

2024-02-12 Thread via GitHub
rahil-c commented on PR #9717: URL: https://github.com/apache/iceberg/pull/9717#issuecomment-1940467823 @geruh when i was trying this pr out, and running `make lint` saw this `recursion` error. ``` ❯ make lint openapi-spec-validator --errors all rest-catalog-open-api.yaml maximum

Re: [PR] Add PrePlanTable and PlanTable Endpoints to open api spec [iceberg]

2024-02-12 Thread via GitHub
rahil-c commented on code in PR #9695: URL: https://github.com/apache/iceberg/pull/9695#discussion_r1487223201 ## open-api/rest-catalog-open-api.yaml: ## @@ -2068,6 +2165,145 @@ components: items: $ref: '#/components/schemas/PartitionStatisticsFile' +

Re: [PR] Add PrePlanTable and PlanTable Endpoints to open api spec [iceberg]

2024-02-12 Thread via GitHub
rahil-c commented on code in PR #9695: URL: https://github.com/apache/iceberg/pull/9695#discussion_r1487222381 ## open-api/rest-catalog-open-api.yaml: ## @@ -2068,6 +2165,145 @@ components: items: $ref: '#/components/schemas/PartitionStatisticsFile' +

Re: [PR] Add PrePlanTable and PlanTable Endpoints to open api spec [iceberg]

2024-02-12 Thread via GitHub
rahil-c commented on code in PR #9695: URL: https://github.com/apache/iceberg/pull/9695#discussion_r1487221999 ## open-api/rest-catalog-open-api.yaml: ## @@ -2068,6 +2165,145 @@ components: items: $ref: '#/components/schemas/PartitionStatisticsFile' +

Re: [PR] OpenAPI: Add AppendDataFileUpdate to TableUpdate for rest appends [iceberg]

2024-02-12 Thread via GitHub
amogh-jahagirdar commented on PR #9717: URL: https://github.com/apache/iceberg/pull/9717#issuecomment-1940452904 Will take a look at this PR tomorrow morning @geruh @jackye1995 ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] Core: Common metadata for TableMetadata and ViewMetadata [iceberg]

2024-02-12 Thread via GitHub
nk1506 commented on code in PR #9682: URL: https://github.com/apache/iceberg/pull/9682#discussion_r1487100635 ## core/src/main/java/org/apache/iceberg/view/ViewMetadata.java: ## @@ -68,21 +61,27 @@ default Integer currentSchemaId() { return currentSchemaId; } + @Value

Re: [I] Support setting a snapshot property in same commit as spark.sql [iceberg-python]

2024-02-12 Thread via GitHub
Gowthami03B commented on issue #368: URL: https://github.com/apache/iceberg-python/issues/368#issuecomment-1940343932 @brianfromoregon @Fokko can I take a stab at this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

Re: [I] Fix header links with underscores in title. [iceberg]

2024-02-12 Thread via GitHub
raghits commented on issue #9617: URL: https://github.com/apache/iceberg/issues/9617#issuecomment-1940303130 @bitsondatadev here are the references where the hyphen (`expire-snapshots`) is used but those are URLs valid and hence I didn't update it: https://github.com/apache/iceberg/blob/

Re: [I] Documentation/FAQ: How does time travel work? [iceberg]

2024-02-12 Thread via GitHub
github-actions[bot] commented on issue #1347: URL: https://github.com/apache/iceberg/issues/1347#issuecomment-1939830688 This issue has been automatically marked as stale because it has been open for 180 days with no activity. It will be closed in next 14 days if no further activity occurs.

Re: [I] Spark 3: Consider providing better support for path-based tables [iceberg]

2024-02-12 Thread via GitHub
github-actions[bot] commented on issue #1306: URL: https://github.com/apache/iceberg/issues/1306#issuecomment-1939830537 This issue has been automatically marked as stale because it has been open for 180 days with no activity. It will be closed in next 14 days if no further activity occurs.

Re: [PR] Spec: Clarify multi-arg transform behavior for different versions [iceberg]

2024-02-12 Thread via GitHub
rdblue commented on code in PR #9661: URL: https://github.com/apache/iceberg/pull/9661#discussion_r1486950821 ## format/spec.md: ## @@ -1314,6 +1324,25 @@ Default values are added to struct fields in v3. Types `timestamp_ns` and `timestamptz_ns` are added in v3. +Sort order

Re: [PR] Spec: Clarify multi-arg transform behavior for different versions [iceberg]

2024-02-12 Thread via GitHub
rdblue commented on code in PR #9661: URL: https://github.com/apache/iceberg/pull/9661#discussion_r1486949549 ## format/spec.md: ## @@ -1130,14 +1142,10 @@ Each partition field in the fields list is stored as an object. See the table fo |**`hour`**|`JSON string: "hour"`|`"hour

Re: [I] Fix header links with underscores in title. [iceberg]

2024-02-12 Thread via GitHub
bitsondatadev commented on issue #9617: URL: https://github.com/apache/iceberg/issues/9617#issuecomment-1939794547 Thanks for this @raghits, have you noticed any other header not using the underscore? -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] Spec: Clarify multi-arg transform behavior for different versions [iceberg]

2024-02-12 Thread via GitHub
rdblue commented on code in PR #9661: URL: https://github.com/apache/iceberg/pull/9661#discussion_r1486925845 ## format/spec.md: ## @@ -1117,7 +1119,17 @@ Partition specs are serialized as a JSON object with the following fields: |**`spec-id`**|`JSON int`|`0`| |**`fields`**|`

Re: [I] Core: complete FileScanTaskParser for other FileScanTask implementation classes (like StaticDataTask) [iceberg]

2024-02-12 Thread via GitHub
stevenzwu commented on issue #9597: URL: https://github.com/apache/iceberg/issues/9597#issuecomment-1939781534 Regarding the `InputFile`, we can serialize the `DataFile` using existing `ContentFileParser` ``` private StaticDataTask( InputFile metadata, Schema tableSchema, Sc

Re: [PR] Spec: Clarify multi-arg transform behavior for different versions [iceberg]

2024-02-12 Thread via GitHub
rdblue commented on code in PR #9661: URL: https://github.com/apache/iceberg/pull/9661#discussion_r1486915191 ## format/spec.md: ## @@ -301,7 +301,7 @@ Tables are configured with a **partition spec** that defines how to produce a tu * A **transform** that is applied to the s

Re: [PR] Spec: Clarify multi-arg transform behavior for different versions [iceberg]

2024-02-12 Thread via GitHub
rdblue commented on code in PR #9661: URL: https://github.com/apache/iceberg/pull/9661#discussion_r1486910753 ## format/spec.md: ## @@ -27,7 +27,7 @@ This is a specification for the Iceberg table format that is designed to manage ## Format Versioning -Versions 1 and 2 of t

Re: [I] InMemoryCatalog's FiloIO in memory map isn't persistent in RestCatalog [iceberg]

2024-02-12 Thread via GitHub
geruh commented on issue #9604: URL: https://github.com/apache/iceberg/issues/9604#issuecomment-1939743479 Synced with @nastra through Slack. This is unexpected behavior, the `RESTCatalog` used to be backed by the `JdbcCatalog` where the ResolvingFileIO knew how to handle this Catalo

[PR] Build: Bump mkdocs-material from 9.5.8 to 9.5.9 [iceberg-python]

2024-02-12 Thread via GitHub
dependabot[bot] opened a new pull request, #418: URL: https://github.com/apache/iceberg-python/pull/418 Bumps [mkdocs-material](https://github.com/squidfunk/mkdocs-material) from 9.5.8 to 9.5.9. Release notes Sourced from https://github.com/squidfunk/mkdocs-material/releases";>mkdo

[PR] Build: Bump sqlalchemy from 2.0.25 to 2.0.26 [iceberg-python]

2024-02-12 Thread via GitHub
dependabot[bot] opened a new pull request, #417: URL: https://github.com/apache/iceberg-python/pull/417 Bumps [sqlalchemy](https://github.com/sqlalchemy/sqlalchemy) from 2.0.25 to 2.0.26. Release notes Sourced from https://github.com/sqlalchemy/sqlalchemy/releases";>sqlalchemy's r

Re: [PR] Add PrePlanTable and PlanTable Endpoints to open api spec [iceberg]

2024-02-12 Thread via GitHub
rahil-c commented on code in PR #9695: URL: https://github.com/apache/iceberg/pull/9695#discussion_r1486866579 ## open-api/rest-catalog-open-api.yaml: ## @@ -2800,6 +3062,58 @@ components: additionalProperties: type: string +PrePlanTableRequest: +

Re: [PR] Add PrePlanTable and PlanTable Endpoints to open api spec [iceberg]

2024-02-12 Thread via GitHub
rahil-c commented on code in PR #9695: URL: https://github.com/apache/iceberg/pull/9695#discussion_r1486864493 ## open-api/rest-catalog-open-api.yaml: ## @@ -2800,6 +3062,58 @@ components: additionalProperties: type: string +PrePlanTableRequest: +

Re: [PR] OpenAPI: Add AppendDataFileUpdate to TableUpdate for rest appends [iceberg]

2024-02-12 Thread via GitHub
jackye1995 commented on code in PR #9717: URL: https://github.com/apache/iceberg/pull/9717#discussion_r1486857635 ## open-api/rest-catalog-open-api.yaml: ## @@ -3324,6 +3348,97 @@ components: type: integer format: int64 +TypeValue: + oneOf: +

Re: [PR] Add PrePlanTable and PlanTable Endpoints to open api spec [iceberg]

2024-02-12 Thread via GitHub
rahil-c commented on code in PR #9695: URL: https://github.com/apache/iceberg/pull/9695#discussion_r1486842085 ## open-api/rest-catalog-open-api.yaml: ## @@ -2574,7 +2810,7 @@ components: allOf: - $ref: "#/components/schemas/TableRequirement" description:

Re: [I] Add metadata tables tests to make sure they don't break when reading different versions of tables [iceberg]

2024-02-12 Thread via GitHub
sfc-gh-aixu commented on issue #2532: URL: https://github.com/apache/iceberg/issues/2532#issuecomment-1939671291 @RussellSpitzer and @yyanyy Seems we haven't made progress with this one. I would like to start with some simple tasks in Iceberg. Can you assign to me? -- This is an automat

[I] Core: checkpoint validation in BaseOverwriteFiles [iceberg]

2024-02-12 Thread via GitHub
hrishisd opened a new issue, #9718: URL: https://github.com/apache/iceberg/issues/9718 ### Feature Request / Improvement ## Request The `SnapshotProducer` API provides the capability to validate that the snapshots in the latest table metadata don't introduce changes that conflict

Re: [PR] OpenAPI: Add AppendDataFileUpdate to TableUpdate for rest appends [iceberg]

2024-02-12 Thread via GitHub
jackye1995 commented on code in PR #9717: URL: https://github.com/apache/iceberg/pull/9717#discussion_r1486825342 ## open-api/rest-catalog-open-api.yaml: ## @@ -2494,6 +2495,28 @@ components: type: integer format: int64 +AppendDataFileUpdate: + a

Re: [PR] OpenAPI: Add AppendDataFileUpdate to TableUpdate for rest appends [iceberg]

2024-02-12 Thread via GitHub
jackye1995 commented on code in PR #9717: URL: https://github.com/apache/iceberg/pull/9717#discussion_r1486826267 ## open-api/rest-catalog-open-api.yaml: ## @@ -2494,6 +2495,28 @@ components: type: integer format: int64 +AppendDataFileUpdate: + a

Re: [PR] OpenAPI: Add AppendDataFileUpdate to TableUpdate for rest appends [iceberg]

2024-02-12 Thread via GitHub
jackye1995 commented on code in PR #9717: URL: https://github.com/apache/iceberg/pull/9717#discussion_r1486817783 ## open-api/rest-catalog-open-api.yaml: ## @@ -3324,6 +3348,97 @@ components: type: integer format: int64 +TypeValue: + oneOf: +

[PR] Feat: Add fail_if_exists param to create_table [iceberg-python]

2024-02-12 Thread via GitHub
hussein-awala opened a new pull request, #415: URL: https://github.com/apache/iceberg-python/pull/415 closes: #406 This PR adds a new parameter `fail_if_exists` to the `Catalog. create_table` (with `True` as a default value to keep the current behavior) method to configure whether to

[PR] OpenAPI: Add AppendDataFileUpdate to TableUpdate for rest appends [iceberg]

2024-02-12 Thread via GitHub
geruh opened a new pull request, #9717: URL: https://github.com/apache/iceberg/pull/9717 Let's split the REST API changes from the implementation, since there is some overlap with the rest scan API. We are now serializing DataFiles using the [ContentFileParser](https://github.com/apache/ice

Re: [PR] Core: Avro writers use BlockingBinaryEncoder to enable array/map size calculations. [iceberg]

2024-02-12 Thread via GitHub
Fokko commented on PR #8625: URL: https://github.com/apache/iceberg/pull/8625#issuecomment-1939558946 @aokolnychyi This is about the Iceberg metadata, not about the Datafiles itself. It might also be interesting for the Datafiles, but then we should analyze the access patterns first. --

[I] Truncate does not support long widths [iceberg]

2024-02-12 Thread via GitHub
JFinis opened a new issue, #9716: URL: https://github.com/apache/iceberg/issues/9716 ### Apache Iceberg version 1.4.3 (latest release) ### Query engine Spark ### Please describe the bug 🐞 This bug is related to https://github.com/apache/iceberg/issues/9715,

Re: [PR] Add PrePlanTable and PlanTable Endpoints to open api spec [iceberg]

2024-02-12 Thread via GitHub
rahil-c commented on code in PR #9695: URL: https://github.com/apache/iceberg/pull/9695#discussion_r1486694391 ## open-api/rest-catalog-open-api.yaml: ## @@ -532,6 +532,103 @@ paths: 5XX: $ref: '#/components/responses/ServerErrorResponse' + /v1/{prefix}/na

Re: [PR] Add PrePlanTable and PlanTable Endpoints to open api spec [iceberg]

2024-02-12 Thread via GitHub
rahil-c commented on code in PR #9695: URL: https://github.com/apache/iceberg/pull/9695#discussion_r1486692273 ## open-api/rest-catalog-open-api.yaml: ## @@ -532,6 +532,103 @@ paths: 5XX: $ref: '#/components/responses/ServerErrorResponse' + /v1/{prefix}/na

Re: [PR] Add PrePlanTable and PlanTable Endpoints to open api spec [iceberg]

2024-02-12 Thread via GitHub
jackye1995 commented on code in PR #9695: URL: https://github.com/apache/iceberg/pull/9695#discussion_r1486680957 ## open-api/rest-catalog-open-api.yaml: ## @@ -2068,6 +2165,145 @@ components: items: $ref: '#/components/schemas/PartitionStatisticsFile'

Re: [PR] Add PrePlanTable and PlanTable Endpoints to open api spec [iceberg]

2024-02-12 Thread via GitHub
jackye1995 commented on code in PR #9695: URL: https://github.com/apache/iceberg/pull/9695#discussion_r1486678553 ## open-api/rest-catalog-open-api.yaml: ## @@ -2068,6 +2165,145 @@ components: items: $ref: '#/components/schemas/PartitionStatisticsFile'

Re: [PR] Add PrePlanTable and PlanTable Endpoints to open api spec [iceberg]

2024-02-12 Thread via GitHub
rahil-c commented on code in PR #9695: URL: https://github.com/apache/iceberg/pull/9695#discussion_r1486676140 ## open-api/rest-catalog-open-api.yaml: ## @@ -532,6 +532,103 @@ paths: 5XX: $ref: '#/components/responses/ServerErrorResponse' + /v1/{prefix}/na

Re: [PR] Add pagination to open api spec for listing of namespaces, tables, views [iceberg]

2024-02-12 Thread via GitHub
jackye1995 commented on code in PR #9660: URL: https://github.com/apache/iceberg/pull/9660#discussion_r1486658218 ## open-api/rest-catalog-open-api.yaml: ## @@ -1482,6 +1490,34 @@ components: explode: false example: "vended-credentials,remote-signing" +page-t

Re: [PR] Add pagination to open api spec for listing of namespaces, tables, views [iceberg]

2024-02-12 Thread via GitHub
jackye1995 commented on code in PR #9660: URL: https://github.com/apache/iceberg/pull/9660#discussion_r1486665098 ## open-api/rest-catalog-open-api.py: ## @@ -629,7 +638,7 @@ class TransformTerm(BaseModel): term: Reference -class ReportMetricsRequest2(CommitReport): +cl

Re: [PR] Add pagination to open api spec for listing of namespaces, tables, views [iceberg]

2024-02-12 Thread via GitHub
jackye1995 commented on code in PR #9660: URL: https://github.com/apache/iceberg/pull/9660#discussion_r1486662620 ## open-api/rest-catalog-open-api.yaml: ## @@ -1581,6 +1617,13 @@ components: type: string example: [ "accounting", "tax" ] +NextPageToken: +

Re: [PR] Add pagination to open api spec for listing of namespaces, tables, views [iceberg]

2024-02-12 Thread via GitHub
jackye1995 commented on code in PR #9660: URL: https://github.com/apache/iceberg/pull/9660#discussion_r1486660713 ## open-api/rest-catalog-open-api.yaml: ## @@ -1482,6 +1490,34 @@ components: explode: false example: "vended-credentials,remote-signing" +page-t

Re: [PR] Add pagination to open api spec for listing of namespaces, tables, views [iceberg]

2024-02-12 Thread via GitHub
jackye1995 commented on code in PR #9660: URL: https://github.com/apache/iceberg/pull/9660#discussion_r1486659809 ## open-api/rest-catalog-open-api.yaml: ## @@ -1482,6 +1490,34 @@ components: explode: false example: "vended-credentials,remote-signing" +page-t

Re: [I] glue.endpoint config implementation? [iceberg-python]

2024-02-12 Thread via GitHub
Fokko commented on issue #414: URL: https://github.com/apache/iceberg-python/issues/414#issuecomment-1939389061 Hey @sebpretzer thanks for reaching out! I think it would be a good addition. We didn't port all the configuration upfront to make sure that we only port the relevant keys. It wou

Re: [PR] Add pagination to open api spec for listing of namespaces, tables, views [iceberg]

2024-02-12 Thread via GitHub
jackye1995 commented on code in PR #9660: URL: https://github.com/apache/iceberg/pull/9660#discussion_r1486658218 ## open-api/rest-catalog-open-api.yaml: ## @@ -1482,6 +1490,34 @@ components: explode: false example: "vended-credentials,remote-signing" +page-t

[I] glue.endpoint config implementation? [iceberg-python]

2024-02-12 Thread via GitHub
sebpretzer opened a new issue, #414: URL: https://github.com/apache/iceberg-python/issues/414 ### Feature Request / Improvement @HonahX @Fokko I was wondering if the `glue.endpoint` config variable could be implemented? Similar to how [s3.endpoint has already been implemented in pyic

Re: [PR] Add pagination to open api spec for listing of namespaces, tables, views [iceberg]

2024-02-12 Thread via GitHub
jackye1995 commented on code in PR #9660: URL: https://github.com/apache/iceberg/pull/9660#discussion_r1486646985 ## open-api/rest-catalog-open-api.yaml: ## @@ -1482,6 +1490,34 @@ components: explode: false example: "vended-credentials,remote-signing" +page-t

Re: [PR] Add pagination to open api spec for listing of namespaces, tables, views [iceberg]

2024-02-12 Thread via GitHub
jackye1995 commented on code in PR #9660: URL: https://github.com/apache/iceberg/pull/9660#discussion_r1486646985 ## open-api/rest-catalog-open-api.yaml: ## @@ -1482,6 +1490,34 @@ components: explode: false example: "vended-credentials,remote-signing" +page-t

Re: [PR] Add pagination to open api spec for listing of namespaces, tables, views [iceberg]

2024-02-12 Thread via GitHub
jackye1995 commented on code in PR #9660: URL: https://github.com/apache/iceberg/pull/9660#discussion_r1486643432 ## open-api/rest-catalog-open-api.yaml: ## @@ -1482,6 +1490,34 @@ components: explode: false example: "vended-credentials,remote-signing" +page-t

Re: [PR] Add PrePlanTable and PlanTable Endpoints to open api spec [iceberg]

2024-02-12 Thread via GitHub
jackye1995 commented on code in PR #9695: URL: https://github.com/apache/iceberg/pull/9695#discussion_r1486639797 ## open-api/rest-catalog-open-api.py: ## @@ -209,6 +209,46 @@ class MetadataLog(BaseModel): __root__: List[MetadataLogItem] +class PlanTask(BaseModel): +

Re: [PR] Add PrePlanTable and PlanTable Endpoints to open api spec [iceberg]

2024-02-12 Thread via GitHub
jackye1995 commented on code in PR #9695: URL: https://github.com/apache/iceberg/pull/9695#discussion_r1486637476 ## open-api/rest-catalog-open-api.yaml: ## @@ -3541,6 +3855,20 @@ components: schema: $ref: '#/components/schemas/LoadTableResult' +Pre

Re: [PR] Add PrePlanTable and PlanTable Endpoints to open api spec [iceberg]

2024-02-12 Thread via GitHub
jackye1995 commented on code in PR #9695: URL: https://github.com/apache/iceberg/pull/9695#discussion_r1486637476 ## open-api/rest-catalog-open-api.yaml: ## @@ -3541,6 +3855,20 @@ components: schema: $ref: '#/components/schemas/LoadTableResult' +Pre

Re: [PR] Add PrePlanTable and PlanTable Endpoints to open api spec [iceberg]

2024-02-12 Thread via GitHub
jackye1995 commented on code in PR #9695: URL: https://github.com/apache/iceberg/pull/9695#discussion_r1486635188 ## open-api/rest-catalog-open-api.yaml: ## @@ -2800,6 +3062,58 @@ components: additionalProperties: type: string +PrePlanTableRequest:

Re: [PR] Add PrePlanTable and PlanTable Endpoints to open api spec [iceberg]

2024-02-12 Thread via GitHub
jackye1995 commented on code in PR #9695: URL: https://github.com/apache/iceberg/pull/9695#discussion_r1486629949 ## open-api/rest-catalog-open-api.yaml: ## @@ -2800,6 +3062,58 @@ components: additionalProperties: type: string +PrePlanTableRequest:

Re: [PR] Add PrePlanTable and PlanTable Endpoints to open api spec [iceberg]

2024-02-12 Thread via GitHub
jackye1995 commented on code in PR #9695: URL: https://github.com/apache/iceberg/pull/9695#discussion_r1486629160 ## open-api/rest-catalog-open-api.yaml: ## @@ -2800,6 +3062,58 @@ components: additionalProperties: type: string +PrePlanTableRequest:

Re: [PR] Add PrePlanTable and PlanTable Endpoints to open api spec [iceberg]

2024-02-12 Thread via GitHub
jackye1995 commented on code in PR #9695: URL: https://github.com/apache/iceberg/pull/9695#discussion_r1486629362 ## open-api/rest-catalog-open-api.yaml: ## @@ -2800,6 +3062,58 @@ components: additionalProperties: type: string +PrePlanTableRequest:

Re: [PR] Add PrePlanTable and PlanTable Endpoints to open api spec [iceberg]

2024-02-12 Thread via GitHub
jackye1995 commented on code in PR #9695: URL: https://github.com/apache/iceberg/pull/9695#discussion_r1486628482 ## open-api/rest-catalog-open-api.yaml: ## @@ -2800,6 +3062,58 @@ components: additionalProperties: type: string +PrePlanTableRequest:

Re: [PR] Add PrePlanTable and PlanTable Endpoints to open api spec [iceberg]

2024-02-12 Thread via GitHub
jackye1995 commented on code in PR #9695: URL: https://github.com/apache/iceberg/pull/9695#discussion_r1486627657 ## open-api/rest-catalog-open-api.yaml: ## @@ -2800,6 +3062,58 @@ components: additionalProperties: type: string +PrePlanTableRequest:

Re: [PR] Add PrePlanTable and PlanTable Endpoints to open api spec [iceberg]

2024-02-12 Thread via GitHub
jackye1995 commented on code in PR #9695: URL: https://github.com/apache/iceberg/pull/9695#discussion_r1486627005 ## open-api/rest-catalog-open-api.yaml: ## @@ -2731,6 +2967,32 @@ components: additionalProperties: type: string +PrePlanTableResult: +

Re: [PR] Add PrePlanTable and PlanTable Endpoints to open api spec [iceberg]

2024-02-12 Thread via GitHub
jackye1995 commented on code in PR #9695: URL: https://github.com/apache/iceberg/pull/9695#discussion_r1486626701 ## open-api/rest-catalog-open-api.yaml: ## @@ -2731,6 +2967,32 @@ components: additionalProperties: type: string +PrePlanTableResult: +

Re: [PR] Add PrePlanTable and PlanTable Endpoints to open api spec [iceberg]

2024-02-12 Thread via GitHub
jackye1995 commented on code in PR #9695: URL: https://github.com/apache/iceberg/pull/9695#discussion_r1486625819 ## open-api/rest-catalog-open-api.yaml: ## @@ -2731,6 +2967,32 @@ components: additionalProperties: type: string +PrePlanTableResult: +

Re: [PR] Add PrePlanTable and PlanTable Endpoints to open api spec [iceberg]

2024-02-12 Thread via GitHub
jackye1995 commented on code in PR #9695: URL: https://github.com/apache/iceberg/pull/9695#discussion_r1486624050 ## open-api/rest-catalog-open-api.yaml: ## @@ -2068,6 +2165,145 @@ components: items: $ref: '#/components/schemas/PartitionStatisticsFile'

Re: [PR] Add PrePlanTable and PlanTable Endpoints to open api spec [iceberg]

2024-02-12 Thread via GitHub
jackye1995 commented on code in PR #9695: URL: https://github.com/apache/iceberg/pull/9695#discussion_r1486624682 ## open-api/rest-catalog-open-api.yaml: ## @@ -2574,7 +2810,7 @@ components: allOf: - $ref: "#/components/schemas/TableRequirement" descriptio

Re: [PR] Add PrePlanTable and PlanTable Endpoints to open api spec [iceberg]

2024-02-12 Thread via GitHub
jackye1995 commented on code in PR #9695: URL: https://github.com/apache/iceberg/pull/9695#discussion_r1486622471 ## open-api/rest-catalog-open-api.yaml: ## @@ -2068,6 +2165,145 @@ components: items: $ref: '#/components/schemas/PartitionStatisticsFile'

Re: [PR] Add PrePlanTable and PlanTable Endpoints to open api spec [iceberg]

2024-02-12 Thread via GitHub
jackye1995 commented on code in PR #9695: URL: https://github.com/apache/iceberg/pull/9695#discussion_r1486619551 ## open-api/rest-catalog-open-api.yaml: ## @@ -2068,6 +2165,145 @@ components: items: $ref: '#/components/schemas/PartitionStatisticsFile'

Re: [PR] Core: Common metadata for TableMetadata and ViewMetadata [iceberg]

2024-02-12 Thread via GitHub
szehon-ho commented on code in PR #9682: URL: https://github.com/apache/iceberg/pull/9682#discussion_r1486600361 ## core/src/main/java/org/apache/iceberg/view/ViewMetadata.java: ## @@ -68,21 +61,27 @@ default Integer currentSchemaId() { return currentSchemaId; } + @Va

Re: [PR] Core: Common metadata for TableMetadata and ViewMetadata [iceberg]

2024-02-12 Thread via GitHub
szehon-ho commented on code in PR #9682: URL: https://github.com/apache/iceberg/pull/9682#discussion_r1484625251 ## core/src/main/java/org/apache/iceberg/view/ViewMetadata.java: ## @@ -68,21 +61,27 @@ default Integer currentSchemaId() { return currentSchemaId; } + @Va

Re: [PR] Kafka Connect: Record converters and delta writers [iceberg]

2024-02-12 Thread via GitHub
bryanck commented on code in PR #9641: URL: https://github.com/apache/iceberg/pull/9641#discussion_r1486549715 ## kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/data/RecordConverter.java: ## @@ -0,0 +1,508 @@ +/* + * Licensed to the Apache Software Foundati

Re: [PR] Add PrePlanTable and PlanTable Endpoints to open api spec [iceberg]

2024-02-12 Thread via GitHub
jackye1995 commented on code in PR #9695: URL: https://github.com/apache/iceberg/pull/9695#discussion_r1486546066 ## open-api/rest-catalog-open-api.yaml: ## @@ -532,6 +532,103 @@ paths: 5XX: $ref: '#/components/responses/ServerErrorResponse' + /v1/{prefix}

Re: [PR] Add PrePlanTable and PlanTable Endpoints to open api spec [iceberg]

2024-02-12 Thread via GitHub
jackye1995 commented on code in PR #9695: URL: https://github.com/apache/iceberg/pull/9695#discussion_r1486544836 ## open-api/rest-catalog-open-api.yaml: ## @@ -532,6 +532,103 @@ paths: 5XX: $ref: '#/components/responses/ServerErrorResponse' + /v1/{prefix}

Re: [PR] Add PrePlanTable and PlanTable Endpoints to open api spec [iceberg]

2024-02-12 Thread via GitHub
jackye1995 commented on code in PR #9695: URL: https://github.com/apache/iceberg/pull/9695#discussion_r1486544836 ## open-api/rest-catalog-open-api.yaml: ## @@ -532,6 +532,103 @@ paths: 5XX: $ref: '#/components/responses/ServerErrorResponse' + /v1/{prefix}

Re: [PR] Add PrePlanTable and PlanTable Endpoints to open api spec [iceberg]

2024-02-12 Thread via GitHub
jackye1995 commented on code in PR #9695: URL: https://github.com/apache/iceberg/pull/9695#discussion_r1486531018 ## open-api/rest-catalog-open-api.yaml: ## @@ -532,6 +532,103 @@ paths: 5XX: $ref: '#/components/responses/ServerErrorResponse' + /v1/{prefix}

Re: [PR] Use SupportsPrefixOperations for Remove OrphanFile Procedure [iceberg]

2024-02-12 Thread via GitHub
carlosescura commented on PR #7914: URL: https://github.com/apache/iceberg/pull/7914#issuecomment-1939197029 Same issue here. I can't run the `remove_orphan_files` procedure using Glue and S3 😢 -- This is an automated message from the Apache Git Service. To respond to the message, please

Re: [PR] Add PrePlanTable and PlanTable Endpoints to open api spec [iceberg]

2024-02-12 Thread via GitHub
jackye1995 commented on code in PR #9695: URL: https://github.com/apache/iceberg/pull/9695#discussion_r1486522192 ## open-api/rest-catalog-open-api.yaml: ## @@ -532,6 +532,103 @@ paths: 5XX: $ref: '#/components/responses/ServerErrorResponse' + /v1/{prefix}

Re: [PR] Add PrePlanTable and PlanTable Endpoints to open api spec [iceberg]

2024-02-12 Thread via GitHub
jackye1995 commented on code in PR #9695: URL: https://github.com/apache/iceberg/pull/9695#discussion_r1486503014 ## open-api/rest-catalog-open-api.yaml: ## @@ -532,6 +532,103 @@ paths: 5XX: $ref: '#/components/responses/ServerErrorResponse' + /v1/{prefix}

Re: [PR] Add PrePlanTable and PlanTable Endpoints to open api spec [iceberg]

2024-02-12 Thread via GitHub
jackye1995 commented on code in PR #9695: URL: https://github.com/apache/iceberg/pull/9695#discussion_r1486503014 ## open-api/rest-catalog-open-api.yaml: ## @@ -532,6 +532,103 @@ paths: 5XX: $ref: '#/components/responses/ServerErrorResponse' + /v1/{prefix}

Re: [PR] Add Thrift and Hive to NOTICE [iceberg-python]

2024-02-12 Thread via GitHub
rdblue commented on PR #410: URL: https://github.com/apache/iceberg-python/pull/410#issuecomment-1939148398 @Fokko, I think that this change is incorrect. It conflicts with the conventions that we use in Avro, Parquet, and the other Iceberg releases. LICENSE is where we put license informat

  1   2   >