szehon-ho commented on code in PR #9661: URL: https://github.com/apache/iceberg/pull/9661#discussion_r1487244304
########## format/spec.md: ########## @@ -1314,6 +1324,25 @@ Default values are added to struct fields in v3. Types `timestamp_ns` and `timestamptz_ns` are added in v3. +Sort order and partition field with multiple source field ids are enabled in V3. + +Writing V3 metadata: + +* Partition field JSON: + * `source-ids` was added and is required + * `source-id` is no longer required and should be omitted; always use `source-ids` instead +* Sort order JSON: + * `source-ids` was added and is required + * `source-id` is no longer required and should be omitted; always use `source-ids` instead + +Reading older version metadata for V3: + +* Partition field and sort order field `source-ids` must default to a single-value list of the value of `source-id` + +Writing older version metadata: + +* Partition field and sort order field `source-ids` should be omitted; use `source-id` instead (multiple values not allowed) Review Comment: Yes, initially was thinking to have a hidden flag to allow V1 and V2 to behave like v3, but you are right we should call it out explicitly. Updated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
