rdblue commented on code in PR #9661: URL: https://github.com/apache/iceberg/pull/9661#discussion_r1486950821
########## format/spec.md: ########## @@ -1314,6 +1324,25 @@ Default values are added to struct fields in v3. Types `timestamp_ns` and `timestamptz_ns` are added in v3. +Sort order and partition field with multiple source field ids are enabled in V3. + +Writing V3 metadata: + +* Partition field JSON: + * `source-ids` was added and is required + * `source-id` is no longer required and should be omitted; always use `source-ids` instead +* Sort order JSON: + * `source-ids` was added and is required + * `source-id` is no longer required and should be omitted; always use `source-ids` instead + +Reading older version metadata for V3: + +* Partition field and sort order field `source-ids` must default to a single-value list of the value of `source-id` + +Writing older version metadata: + +* Partition field and sort order field `source-ids` should be omitted; use `source-id` instead (multiple values not allowed) Review Comment: This would prevent v1 and v2 from using multi-arg transforms, but I think that should be supported and should be chosen by the client. See my suggestion above, which explains what to do for compatibility. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
