rdblue commented on PR #410: URL: https://github.com/apache/iceberg-python/pull/410#issuecomment-1939148398
@Fokko, I think that this change is incorrect. It conflicts with the conventions that we use in Avro, Parquet, and the other Iceberg releases. LICENSE is where we put license information for code. NOTICE is for legally required notifications only. Here's the documentation on NOTICE: > ### Modifications to NOTICE[ΒΆ](https://infra.apache.org/licensing-howto.html#mod-notice) > The NOTICE file is reserved for a certain subset of legally required notifications which are not satisfied by either the text of LICENSE or the presence of licensing information embedded within the bundled dependency. Aside from Apache-licensed dependencies which supply NOTICE files of their own, it is uncommon for a dependency to require additions to NOTICE. > > Copyright notifications which have been [relocated](https://www.apache.org/legal/src-headers.html#headers), rather than removed, from source files must be preserved in NOTICE. However, elements such as the copyright notifications embedded within BSD and MIT licenses [do not need to be duplicated](https://issues.apache.org/jira/browse/LEGAL-59) in NOTICE. You can leave those notices in their original locations. > > It is important to keep NOTICE as brief and simple as possible, as each addition places a burden on downstream consumers. > > Do not add anything to NOTICE which is not legally required. Legally required notifications are things like attribution required by third-party licenses. We also include sections of other NOTICE files that need to be preserved because they apply to this project as well as the original project. License information should be included in the LICENSE file because it is the canonical place for license attribution. That's why the documentation states that NOTICE is for "notifications which are not satisfied by either the text of LICENSE or ..." It's fine if we don't ship code and should update LICENSE to reflect that, but we can't add this information to NOTICE. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
