nastra commented on code in PR #58: URL: https://github.com/apache/iceberg-go/pull/58#discussion_r1487326967
########## cmd/iceberg/main.go: ########## @@ -0,0 +1,332 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +package main + +import ( + "context" + "errors" + "fmt" + "log" + "os" + "strings" + + "github.com/apache/iceberg-go" + "github.com/apache/iceberg-go/catalog" + "github.com/apache/iceberg-go/table" + "github.com/docopt/docopt-go" +) + +const usage = `iceberg. + +Usage: + iceberg list [options] [PARENT] Review Comment: Yes I saw that, but ``` Usage: iceberg list [options] [PARENT] iceberg describe [options] [namespace | table] IDENTIFIER iceberg (schema | spec | uuid | location) [options] TABLE_ID iceberg drop [options] (namespace | table) IDENTIFIER iceberg files [options] TABLE_ID [--history] iceberg rename [options] <from> <to> iceberg properties [options] get (namespace | table) IDENTIFIER [PROPNAME] iceberg properties [options] set (namespace | table) IDENTIFIER PROPNAME VALUE iceberg properties [options] remove (namespace | table) IDENTIFIER PROPNAME iceberg -h | --help | --version Arguments: PARENT Catalog parent namespace IDENTIFIER fully qualified namespace or table TABLE_ID full path to a table PROPNAME name of a property VALUE value to set Options: -h --help show this helpe messages and exit --catalog TEXT specify the catalog type [default: rest] --uri TEXT specify the catalog URI --output TYPE output type (json/text) [default: text] --credential TEXT specify credentials for the catalog ``` isn't super informative. What I meant is having some sort of better description of the different commands, similar to ``` Commands: describe Describes a namespace xor table drop Operations to drop a namespace or table list Lists tables or namespaces location Returns the location of the table properties Properties on tables/namespaces rename Renames a table schema Gets the schema of the table spec Returns the partition spec of the table uuid Returns the UUID of the table ``` Again, this isn't in the scope of this PR and would be nice to improve eventually -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
