jackye1995 commented on code in PR #9660:
URL: https://github.com/apache/iceberg/pull/9660#discussion_r1486662620


##########
open-api/rest-catalog-open-api.yaml:
##########
@@ -1581,6 +1617,13 @@ components:
         type: string
       example: [ "accounting", "tax" ]
 
+    NextPageToken:
+      description:
+        An opaque next page token, when non-empty this indicates that more 
results can be returned by server,
+        and when empty this indicates the returned results are complete.

Review Comment:
   I think we do not need to do that. We did it for pageToken query parameter 
for backwards compatibility. But the fact that not returning this value is 
already backwards compatible, I think we should not have a special case for 
empty value.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to