jackye1995 commented on code in PR #9695:
URL: https://github.com/apache/iceberg/pull/9695#discussion_r1486619551


##########
open-api/rest-catalog-open-api.yaml:
##########
@@ -2068,6 +2165,145 @@ components:
           items:
             $ref: '#/components/schemas/PartitionStatisticsFile'
 
+    PlanTask:
+      description:
+        A flexible JSON object that contains information provided by the 
server,
+        to be utilized by clients for distributed planning. However it is 
recommended that servers
+        provide a plan-task-id, as well as a location to a manifest.
+      type: object
+
+    FileScanTask:
+      type: object
+      required:
+        - data-file

Review Comment:
   I think quite a few things are required, based on 
FileScanTaskParser.fromJson. 
   
   And interestingly data-file is actually not required:
   
   ```
   DataFile dataFile = null;
       if (jsonNode.has(DATA_FILE)) {
         dataFile = (DataFile) 
ContentFileParser.fromJson(jsonNode.get(DATA_FILE), spec);
       }
   ```
   
   Although I am not sure why the parser decides to allow null for the data 
file. @stevenzwu could you help explain that?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to