nk1506 commented on code in PR #9682:
URL: https://github.com/apache/iceberg/pull/9682#discussion_r1487100635
##########
core/src/main/java/org/apache/iceberg/view/ViewMetadata.java:
##########
@@ -68,21 +61,27 @@ default Integer currentSchemaId() {
return currentSchemaId;
}
+ @Value.Parameter(order = 1001)
+ String uuid();
+
+ @Value.Parameter(order = 1002)
+ int formatVersion();
+
Review Comment:
@szehon-ho , Since we are planning to keep common members with ViewMetadata
too with `@Override`. Do we have a need of keeping `@Value.Parameter` in
ViewMetadata. I think only override should works.
WDYT ? I have updated the patch with only `@Override` and removed
`@Value.Parameter` from everywhere.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
