nastra commented on code in PR #9670:
URL: https://github.com/apache/iceberg/pull/9670#discussion_r1487312284
##########
spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestDelete.java:
##########
@@ -322,9 +302,11 @@ public void testDeleteWithoutScanningTable() throws
Exception {
sql("SELECT * FROM %s ORDER BY id", selectTarget()));
}
- @Test
+ @TestTemplate
public void testDeleteFileThenMetadataDelete() throws Exception {
- Assume.assumeFalse("Avro does not support metadata delete",
fileFormat.equals("avro"));
+ assumeThat(fileFormat.equalsIgnoreCase("avro"))
Review Comment:
once `fileFormat` is of type `FileFormat`, this check can be changed to
`assumeThat(fileFormat).as(..).isNotEqualTo(FileFormat.AVRO)`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
