szehon-ho commented on code in PR #9682:
URL: https://github.com/apache/iceberg/pull/9682#discussion_r1484625251


##########
core/src/main/java/org/apache/iceberg/view/ViewMetadata.java:
##########
@@ -68,21 +61,27 @@ default Integer currentSchemaId() {
     return currentSchemaId;
   }
 
+  @Value.Parameter(order = 1001)
+  String uuid();
+
+  @Value.Parameter(order = 1002)
+  int formatVersion();
+

Review Comment:
   Yea exactly, is it possible to remove @Value.Parameter in the BaseMetadata, 
and keep the annotations all in the ViewMetadata.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to