jackye1995 commented on code in PR #9695: URL: https://github.com/apache/iceberg/pull/9695#discussion_r1486531018
########## open-api/rest-catalog-open-api.yaml: ########## @@ -532,6 +532,103 @@ paths: 5XX: $ref: '#/components/responses/ServerErrorResponse' + /v1/{prefix}/namespaces/{namespace}/tables/{table}/preplan: + parameters: + - $ref: '#/components/parameters/prefix' + - $ref: '#/components/parameters/namespace' + - $ref: '#/components/parameters/table' + post: + tags: + - Catalog API + summary: Intiate a preplanning process on the table to find plan-tasks relevant to a specific query. + description: + When a user submits a query, we can do a "preplan" to find the relevant plan-tasks + based on the user's selected columns, and filters. The plan-tasks can then be used during "plan" + for distributed planning for performance gain. + operationId: prePlan + requestBody: + content: + application/json: + schema: + $ref: '#/components/schemas/PrePlanTableRequest' Review Comment: just nit about the word "preplan", looks like it can exist either as one whole word, or two words `pre-plan`: https://www.merriam-webster.com/dictionary/preplan I think we should be consistent for this wording in the spec. If `preplan` is the word we will always use, We should always stick to `Preplan` instead of `PrePlan` for camel casing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org