jackye1995 commented on code in PR #9660:
URL: https://github.com/apache/iceberg/pull/9660#discussion_r1486658218
##########
open-api/rest-catalog-open-api.yaml:
##########
@@ -1482,6 +1490,34 @@ components:
explode: false
example: "vended-credentials,remote-signing"
+ page-token:
+ name: pageToken
+ in: query
+ description:
+ An opaque token which allows clients to make use of pagination by
signaling to the service that they would
+ prefer requests to be paginated based on the number of items specified
by pageSize.
+
+ Clients that support pagination initiate the request by sending an
empty pageToken e.g. GET /tables?pageToken
Review Comment:
I think we need to decide what exactly does it mean to be an empty token,
and how it is used in the REST call.
I can see 3 ways:
1. `GET /tables?pageToken&pageSize=10`
2. `GET /tables?pageToken=&pageSize=10`
3. `GET /tables?pageToken=%02%03&pageSize=10`
(these are options described in
https://stackoverflow.com/questions/21423113/passing-empty-string-parameter-in-url)
I personally think option 3 is the most clear and not ambiguous one, and
similar to how we handle dots in namespace names. We also do not need to worry
about the capability of different frameworks and languages in handling empty
string or non-key-value query parameter. Any thoughts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
