nastra commented on code in PR #9670:
URL: https://github.com/apache/iceberg/pull/9670#discussion_r1487315985
##########
spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestDelete.java:
##########
@@ -884,9 +867,9 @@ public void testDeleteWithNotInSubquery() throws
NoSuchTableException {
sql("SELECT * FROM %s ORDER BY id ASC NULLS LAST", selectTarget()));
}
- @Test
+ @TestTemplate
public void testDeleteOnNonIcebergTableNotSupported() {
- Assume.assumeTrue(catalogName.equalsIgnoreCase("spark_catalog"));
+ assumeThat(catalogName.equalsIgnoreCase("spark_catalog")).isTrue();
Review Comment:
same as above
##########
spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestDelete.java:
##########
@@ -1015,20 +998,21 @@ public void testDeleteThatRequiresGroupingBeforeWrite()
throws NoSuchTableExcept
spark.conf().set("spark.sql.shuffle.partitions", "1");
sql("DELETE FROM %s t WHERE id IN (SELECT * FROM deleted_id)",
commitTarget());
- Assert.assertEquals(
- "Should have expected num of rows", 8L,
spark.table(commitTarget()).count());
+ assertThat(spark.table(commitTarget()).count())
+ .as("Should have expected num of rows")
+ .isEqualTo(8L);
} finally {
spark.conf().set("spark.sql.shuffle.partitions",
originalNumOfShufflePartitions);
}
}
- @Test
+ @TestTemplate
public synchronized void testDeleteWithSerializableIsolation() throws
InterruptedException {
// cannot run tests with concurrency for Hadoop tables without atomic
renames
- Assume.assumeFalse(catalogName.equalsIgnoreCase("testhadoop"));
+ assumeThat(catalogName.equalsIgnoreCase("testhadoop")).isFalse();
Review Comment:
same as above
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
