Chris Morrissey has posted comments on this change.
Change subject: restapi: Added "scan" to disks resource to import clones
..
Patch Set 1: (6 inline comments)
Responded to comments. Working on patch set 2 to be delivered shor
Mike Kolesnik has posted comments on this change.
Change subject: engine,webadmin: Remove getNetwork from NetworkView
..
Patch Set 2: (2 inline comments)
File
frontend/webad
Roy Golan has posted comments on this change.
Change subject: core: renamed AdUser to LdapUser.
..
Patch Set 1: (11 inline comments)
minor comments around renaming also args and comments
...
Oved Ourfali has posted comments on this change.
Change subject: restapi: if filter: header is set, use query instead of search
(#869334)
..
Patch Set 3: Looks good to me, but someone else must approve
--
To view, visit http:/
ofri masad has posted comments on this change.
Change subject: core: Added "scan" to disks resource to import clones
..
Patch Set 2: I would prefer that you didn't submit this
--
To view, visit http://gerrit.ovirt.org/9603
To u
ofri masad has posted comments on this change.
Change subject: core: Added "scan" to disks resource to import clones
..
Patch Set 1: (1 inline comment)
File
backend/manager/
ofri masad has posted comments on this change.
Change subject: core: Added "scan" to disks resource to import clones
..
Patch Set 2: (2 inline comments)
File
backend/manager
ofri masad has posted comments on this change.
Change subject: webadmin: missing translation in Quota ($VmName)
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/9662
To u
Yair Zaslavsky has posted comments on this change.
Change subject: core: Rename ad_groups class to LdapGroup
..
Patch Set 4: (2 inline comments)
File
backend/manager/modules
Yair Zaslavsky has submitted this change and it was merged.
Change subject: core: remove unused ldap class.
..
core: remove unused ldap class.
org/ovirt/engine/core/common/businessentities/ad_vm_pool_group_map.java is
unused.
Yair Zaslavsky has posted comments on this change.
Change subject: core: remove unused ldap class.
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10010
To unsubscribe, visit http:
Yair Zaslavsky has posted comments on this change.
Change subject: core: renamed AdUser to LdapUser.
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/10014
To unsubscribe
Vinzenz Feenstra has posted comments on this change.
Change subject: agent: apply virtual-guest tuning profile on installation.
..
Patch Set 1: I would prefer that you didn't submit this
A RPM must not change the configuration
Itamar Heim has posted comments on this change.
Change subject: packaging: Fix comment in /etc/sysconfig/ovirt-engine
..
Patch Set 1:
i agree with alon, even a +1 from any reviewer should be good enough for
something like this
Einav Cohen has posted comments on this change.
Change subject: webadmin: Added the ability to define a 'no items' message.
..
Patch Set 4: (1 inline comment)
File
frontend/
Alexander Wels has posted comments on this change.
Change subject: webadmin: Added the ability to define a 'no items' message.
..
Patch Set 4: (1 inline comment)
File
fronte
Ayal Baron has posted comments on this change.
Change subject: core: ImportVm cleanup: canDoAction_beforeCloneVM
..
Patch Set 8: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/9621
To
Ayal Baron has posted comments on this change.
Change subject: core: ImportVm cleanup: action and type params
..
Patch Set 8: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/9620
To uns
Einav Cohen has posted comments on this change.
Change subject: webadmin: Added the ability to define a 'no items' message.
..
Patch Set 4: (1 inline comment)
File
frontend/
Daniel Erez has posted comments on this change.
Change subject: webadmin: Added the ability to define a 'no items' message.
..
Patch Set 4: (1 inline comment)
File
frontend/
Alexander Wels has posted comments on this change.
Change subject: webadmin: Added the ability to define a 'no items' message.
..
Patch Set 4: (1 inline comment)
File
fronte
Alexander Wels has posted comments on this change.
Change subject: webadmin: Added the ability to define a 'no items' message.
..
Patch Set 4: No score
(2 inline comments)
F
Alon Bar-Lev has posted comments on this change.
Change subject: common: config: fix LDAPConnectTimeout in properties
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/10015
To unsubscribe, visit http://gerrit.
Alon Bar-Lev has uploaded a new change for review.
Change subject: common: config: fix LDAPConnectTimeout in properties
..
common: config: fix LDAPConnectTimeout in properties
Change-Id: I528b0b631cababf77bfc5830036d8f0785ce4529
Sharad Mishra has posted comments on this change.
Change subject: core: renamed AdUser to LdapUser.
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/10014
To unsubscribe, visit http://gerrit.ovirt.org/settings
Ayal Baron has posted comments on this change.
Change subject: core: ImportVm test cleanup: Use StringUtil.repeat
..
Patch Set 7: (2 inline comments)
File
backend/manager/mo
Ayal Baron has posted comments on this change.
Change subject: core: ImportVm test cleanup: stop spying
..
Patch Set 6: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/9618
To unsubscri
Sharad Mishra has posted comments on this change.
Change subject: core: remove unused ldap class.
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/10010
To unsubscribe, visit http://gerrit.ovirt.org/settings
Sharad Mishra has uploaded a new change for review.
Change subject: core: remove unused ldap class.
..
core: remove unused ldap class.
org/ovirt/engine/core/common/businessentities/ad_vm_pool_group_map.java is
unused.
Change-I
Sharad Mishra has posted comments on this change.
Change subject: core: ImagesHandler.setDiskAlias early return
..
Patch Set 8: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/9658
To u
Sharad Mishra has posted comments on this change.
Change subject: core: ImagesHandler: error instead of errorFormat
..
Patch Set 3: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/9797
Sharad Mishra has posted comments on this change.
Change subject: core: ImportVm test cleanup: Don't mock DAOs
..
Patch Set 10: (1 inline comment)
File
backend/manager/modul
Project: http://jenkins.ovirt.org/job/ovirt-mom_create_rpms/
Build: http://jenkins.ovirt.org/job/ovirt-mom_create_rpms/21/
Build Number: 21
Build Status: Fixed
Triggered By: Started by user Adam Litke
-
Changes Since Last Success:
-
Yair Zaslavsky has posted comments on this change.
Change subject: core: Newly added domain is always before the old one
..
Patch Set 5: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/9140
To uns
Yair Zaslavsky has submitted this change and it was merged.
Change subject: core: Newly added domain is always before the old one
..
core: Newly added domain is always before the old one
When a domain is added using engine-mana
Project: http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/
Build: http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/2884/
Build Number: 2884
Build Status: Fixed
Triggered By: Started by upstream project "ovirt_engine" build number 3,617,
Started by upstream project "ovirt_engine" build nu
Ravi Nori has posted comments on this change.
Change subject: core: ImportVm test cleanup: Don't mock DAOs
..
Patch Set 10: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/9626
To unsub
Ravi Nori has posted comments on this change.
Change subject: core: Newly added domain is always before the old one
..
Patch Set 5: Verified
No Code changes, rebased and pushed
--
To view, visit http://gerrit.ovirt.org/9140
To
Allon Mureinik has posted comments on this change.
Change subject: core: Add NetworkLinking support to OvfVm.
..
Patch Set 4: No score; Looks good to me, but someone else must approve
Sorry, +1, not verified.
Wrong checkbox.
-
Allon Mureinik has submitted this change and it was merged.
Change subject: engine: search disks does not complete bootable and shareable
..
engine: search disks does not complete bootable and shareable
Search engine does not c
Allon Mureinik has posted comments on this change.
Change subject: engine: search disks does not complete bootable and shareable
..
Patch Set 3: Looks good to me, approved
+2 also given by Eli in previous patch (no code changes
Allon Mureinik has posted comments on this change.
Change subject: core: Remove SQL Server specific code
..
Patch Set 3: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/9580
To unsubscr
Project: http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/
Build: http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/2883/
Build Number: 2883
Build Status: Still Unstable
Triggered By: Started by upstream project "ovirt_engine" build number 3,616
-
Chang
Allon Mureinik has posted comments on this change.
Change subject: core: Add NetworkLinking support to OvfVm.
..
Patch Set 4: Verified
--
To view, visit http://gerrit.ovirt.org/9802
To unsubscribe, visit http://gerrit.ovirt.org
Ravi Nori has posted comments on this change.
Change subject: engine: search disks does not complete bootable and shareable
..
Patch Set 3: Verified
Rebased and fixed commit message
--
To view, visit http://gerrit.ovirt.org/93
Allon Mureinik has posted comments on this change.
Change subject: engine: search does not complete boolean fields values
..
Patch Set 2: Looks good to me, but someone else must approve
(1 inline comment)
The code looks fine t
Allon Mureinik has posted comments on this change.
Change subject: core: ImportVm: disk alias with copyCollapse=false
..
Patch Set 12: Verified
Rebased, no code changes.
--
To view, visit http://gerrit.ovirt.org/9631
To unsubs
Allon Mureinik has posted comments on this change.
Change subject: core: ImportVm: Add test for addImagesAndSnapshots
..
Patch Set 10: Verified
Rebased, no code changes.
--
To view, visit http://gerrit.ovirt.org/9630
To unsubs
Allon Mureinik has posted comments on this change.
Change subject: core: ImportVm: fix disk alias generation
..
Patch Set 10: Verified
Rebased, no code changes.
--
To view, visit http://gerrit.ovirt.org/9629
To unsubscribe, vi
Allon Mureinik has posted comments on this change.
Change subject: core: ImagesHandler: error instead of errorFormat
..
Patch Set 3: Verified
Rebased, no code changes.
--
To view, visit http://gerrit.ovirt.org/9797
To unsubscr
Allon Mureinik has posted comments on this change.
Change subject: core: ImagesHandler.setDiskAlias early return
..
Patch Set 8: Verified
Rebased, no code changes.
--
To view, visit http://gerrit.ovirt.org/9658
To unsubscribe,
Allon Mureinik has posted comments on this change.
Change subject: core: ImportVm test: activate insufficientDiskSpace
..
Patch Set 10: Verified
Rebased, no code changes.
--
To view, visit http://gerrit.ovirt.org/9628
To unsub
Allon Mureinik has posted comments on this change.
Change subject: core: ImportVm cleanup: Remove TestHelperImportVm
..
Patch Set 10: Verified
Rebased, no code changes.
--
To view, visit http://gerrit.ovirt.org/9627
To unsubsc
Allon Mureinik has posted comments on this change.
Change subject: core: ImportVm test cleanup: Don't mock DAOs
..
Patch Set 10: Verified
Rebased, no code changes.
--
To view, visit http://gerrit.ovirt.org/9626
To unsubscribe,
Allon Mureinik has posted comments on this change.
Change subject: core: GetAllFromExportDomainQueryParameters.getAll
..
Patch Set 8: Verified
Rebased, no code changes.
--
To view, visit http://gerrit.ovirt.org/9625
To unsubsc
Allon Mureinik has posted comments on this change.
Change subject: core: ImportVm cleanup: canDoActionXXX conventions
..
Patch Set 8: Verified
rebased, consolidated changes in the previous patch
--
To view, visit http://gerrit
Allon Mureinik has posted comments on this change.
Change subject: core: ImportVm cleanup: canDoAction
..
Patch Set 8: Verified
rebased, removed the "if" in the return statement of canDoAction_afterCloneVm
--
To view, visit ht
Allon Mureinik has posted comments on this change.
Change subject: core: ImportVm cleanup: CDA_afterCloneVm signature
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/10007
To unsubscribe, visit http://gerrit.
Allon Mureinik has posted comments on this change.
Change subject: core: ImportVm cleanup: canDoAction_afterCloneVm
..
Patch Set 8: Verified
Rebased, no code changes.
--
To view, visit http://gerrit.ovirt.org/9622
To unsubscri
Allon Mureinik has posted comments on this change.
Change subject: core: ImportVm cleanup: CDA_beforeCloneVm sig.
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/10006
To unsubscribe, visit http://gerrit.ovir
Allon Mureinik has posted comments on this change.
Change subject: core: ImportVm cleanup: canDoAction_beforeCloneVM
..
Patch Set 8: Verified
Rebased, no code changes.
--
To view, visit http://gerrit.ovirt.org/9621
To unsubscr
Allon Mureinik has posted comments on this change.
Change subject: core: ImportVm cleanup: action and type params
..
Patch Set 8: Verified
Rebased, no code changes.
--
To view, visit http://gerrit.ovirt.org/9620
To unsubscribe
Allon Mureinik has posted comments on this change.
Change subject: core: ImportVm test cleanup: Use StringUtil.repeat
..
Patch Set 7: Verified
Rebased, no code changes.
--
To view, visit http://gerrit.ovirt.org/9619
To unsubsc
Allon Mureinik has posted comments on this change.
Change subject: core: ImportVm test cleanup: stop spying
..
Patch Set 6: Verified
Rebased, no code changes.
--
To view, visit http://gerrit.ovirt.org/9618
To unsubscribe, visi
Allon Mureinik has submitted this change and it was merged.
Change subject: core: ImportVm test cleanup: remove spring
..
core: ImportVm test cleanup: remove spring
Remove wrongfully used spring validation assertions and replac
Allon Mureinik has posted comments on this change.
Change subject: core: ImportVm test cleanup: remove spring
..
Patch Set 6: Verified; Looks good to me, approved
Rebased, no code changes.
+2 by Laszlo.
--
To view, visit http:
Allon Mureinik has submitted this change and it was merged.
Change subject: core: ImportVm test cleanup: createVm return
..
core: ImportVm test cleanup: createVm return
Inline the return statement in createVm(), for better read
Allon Mureinik has posted comments on this change.
Change subject: core: ImportVm test cleanup: createVm return
..
Patch Set 3: Verified; Looks good to me, approved
Rebased, no code changes.
+2 by Tal.
--
To view, visit http:/
Allon Mureinik has submitted this change and it was merged.
Change subject: core: ImportVm cleanup: iterate maps values()
..
core: ImportVm cleanup: iterate maps values()
Iterate of VM's disks map values() instead of iterating
Allon Mureinik has posted comments on this change.
Change subject: core: ImportVm cleanup: iterate maps values()
..
Patch Set 6: Verified; Looks good to me, approved
Rebased, no code changes.
+2 by Tal, +1 by Maor.
--
To view,
Allon Mureinik has uploaded a new change for review.
Change subject: core: ImportVm cleanup: CDA_beforeCloneVm sig.
..
core: ImportVm cleanup: CDA_beforeCloneVm sig.
Stop passing canDoAction to canDoAction_beforeCloneVm, as it i
Allon Mureinik has uploaded a new change for review.
Change subject: core: ImportVm cleanup: CDA_afterCloneVm signature
..
core: ImportVm cleanup: CDA_afterCloneVm signature
Stop passing canDoActionMessages to canDoAction_afterC
Omer Frenkel has posted comments on this change.
Change subject: engine: Introducing a queue for failovers event
..
Patch Set 1: (1 inline comment)
what about calls to reconstruct (and other relevant commands) not from the
eve
Allon Mureinik has posted comments on this change.
Change subject: core: ImportVm: Add test for addImagesAndSnapshots
..
Patch Set 9: (1 inline comment)
File
backend/manager
Allon Mureinik has posted comments on this change.
Change subject: core: ImagesHandler.setDiskAlias early return
..
Patch Set 7: (1 inline comment)
File
backend/manager/modu
Allon Mureinik has posted comments on this change.
Change subject: core: ImportVm test cleanup: Don't mock DAOs
..
Patch Set 9: (1 inline comment)
File
backend/manager/modul
Allon Mureinik has posted comments on this change.
Change subject: core: ImportVm cleanup: canDoAction
..
Patch Set 7: (1 inline comment)
File
backend/manager/modules/bll/sr
Moti Asayag has submitted this change and it was merged.
Change subject: engine: Modify excepted exception to match impl
..
engine: Modify excepted exception to match impl
The patch modifies the expected exception to the
correc
Moti Asayag has posted comments on this change.
Change subject: engine: Modify excepted exception to match impl
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/10005
To unsubscribe, visit http://gerrit.ovirt.
Yair Zaslavsky has posted comments on this change.
Change subject: engine: Modify excepted exception to match impl
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10005
To unsubscribe, visit
Moti Asayag has uploaded a new change for review.
Change subject: engine: Modify excepted exception to match impl
..
engine: Modify excepted exception to match impl
The patch modifies the expected exception to the
correct packag
Project: http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/
Build: http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/2882/
Build Number: 2882
Build Status: Unstable
Triggered By: Started by upstream project "ovirt_engine" build number 3,607,
Started by upstream project "ovirt_engine" build
Project: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/
Build: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/2983/
Build Number: 2983
Build Status: Fixed
Triggered By: Started by upstream project "ovirt_engine" build number 3,612
-
Changes Since La
Project: http://jenkins.ovirt.org/job/ovirt_engine_dao_unit_tests/
Build: http://jenkins.ovirt.org/job/ovirt_engine_dao_unit_tests/2674/
Build Number: 2674
Build Status: Fixed
Triggered By: Started by upstream project "ovirt_engine" build number 3,614
-
Change
Mike Kolesnik has submitted this change and it was merged.
Change subject: engine: Modify Network Assign to Cluster Command permissions
..
engine: Modify Network Assign to Cluster Command permissions
The patch modifies the requ
Mike Kolesnik has posted comments on this change.
Change subject: engine: Modify Network Assign to Cluster Command permissions
..
Patch Set 13: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/9540
To unsubs
Moti Asayag has posted comments on this change.
Change subject: engine: Modify Network Assign to Cluster Command permissions
..
Patch Set 13: Verified
--
To view, visit http://gerrit.ovirt.org/9540
To unsubscribe, visit http://
Roy Golan has uploaded a new change for review.
Change subject: core: call Failed to runVms on different thread
..
core: call Failed to runVms on different thread
on a busy system we can hit a deadlock in a situation where 2 Vds
Mike Kolesnik has posted comments on this change.
Change subject: engine: Modify Network Assign to Cluster Command permissions
..
Patch Set 11: (2 inline comments)
File
back
Michael Kublin has posted comments on this change.
Change subject: core: Remove global lock on SPM calls from engine side
..
Patch Set 5: Verified
If I will not have any response, I will merge it by myself.
If you have to say s
Moti Asayag has posted comments on this change.
Change subject: engine: Modify Network Assign to Cluster Command permissions
..
Patch Set 11: Verified
--
To view, visit http://gerrit.ovirt.org/9540
To unsubscribe, visit http://
Moti Asayag has submitted this change and it was merged.
Change subject: engine: Extracts permission check algorithm
..
engine: Extracts permission check algorithm
The patch extracts the permission check algorithm so it could b
Moti Asayag has posted comments on this change.
Change subject: engine: Extracts permission check algorithm
..
Patch Set 5: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/9847
To unsubscribe, vis
Moti Asayag has submitted this change and it was merged.
Change subject: engine: Use proper dao api to detect used network
..
engine: Use proper dao api to detect used network
The patch simplifies the code of RemoveNetworkComma
Moti Asayag has posted comments on this change.
Change subject: engine: Use proper dao api to detect used network
..
Patch Set 6: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/9833
To unsubscrib
Moti Asayag has submitted this change and it was merged.
Change subject: engine: Cleanup network commands
..
engine: Cleanup network commands
Avoid static access to DbFacade instance.
Change-Id: Idc02f4024b3c33cee5260bb82b03c2
Moti Asayag has posted comments on this change.
Change subject: engine: Cleanup network commands
..
Patch Set 11: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/9546
To unsubscribe, visit http://
Mike Kolesnik has submitted this change and it was merged.
Change subject: engine: Restrict viewable networks by the User
..
engine: Restrict viewable networks by the User
The patch restricts the viewable network by the user fo
Mike Kolesnik has posted comments on this change.
Change subject: engine: Restrict viewable networks by the User
..
Patch Set 11: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/9545
To unsubscribe, visit h
Moti Asayag has posted comments on this change.
Change subject: engine: Restrict viewable networks by the User
..
Patch Set 11: Verified
--
To view, visit http://gerrit.ovirt.org/9545
To unsubscribe, visit http://gerrit.ovirt.o
1 - 100 of 275 matches
Mail list logo
