Allon Mureinik has posted comments on this change.
Change subject: core: ImportVm cleanup: canDoAction
......................................................................
Patch Set 7: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java
Line 128: protected boolean canDoAction() {
Line 129: List<String> canDoActionMessages =
getReturnValue().getCanDoActionMessages();
Line 130: Map<Guid, storage_domains> domainsMap = new HashMap<Guid,
storage_domains>();
Line 131:
Line 132: if (!canDoAction_beforeCloneVm(canDoActionMessages,
domainsMap)) {
Agree - will fix in another patch. I want to keep this patch about the early
return only.
Line 133: return false;
Line 134: }
Line 135:
Line 136: if (getParameters().isImportAsNewEntity()) {
--
To view, visit http://gerrit.ovirt.org/9623
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icbc4f72d5ce9df230b3d1480a055c603f470770e
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Alissa Bonas <abo...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Ayal Baron <aba...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Liron Aravot <lara...@redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com>
Gerrit-Reviewer: Tal Nisan <tni...@redhat.com>
Gerrit-Reviewer: Vered Volansky <vvola...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
