Alexander Wels has posted comments on this change.
Change subject: webadmin: Added the ability to define a 'no items' message.
......................................................................
Patch Set 4: No score
(2 inline comments)
....................................................
File
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java
Line 2434: String detachGlusterHostsHostAddress();
Line 2435:
Line 2436: @DefaultStringValue("Detach the hosts forcefully")
Line 2437: String detachGlusterHostsForcefully();
Line 2438:
I originally did this, however I am not 100% positive we can build sentences
like that in every language. I didn't want to restrict the translators ability
to properly translate the sentence.
Line 2439: //No items to display messages.
Line 2440: @DefaultStringValue("No Data Centers to display")
Line 2441: String noDataCentersToDisplay();
Line 2442:
....................................................
File
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/AbstractMainTabTableView.java
Line 62: }
Line 63:
Line 64: protected String getTableTypeString() {
Line 65: //Sub classes can override this to get a specific message.
Line 66: return null;
Actually nothing is actually using this code. It is a leftover from one of my
iterations through this. I will be removing this.
Line 67: }
--
To view, visit http://gerrit.ovirt.org/9830
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If808e7c1bc92877d3f59b766985900a2c8ffd216
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alexander Wels <aw...@redhat.com>
Gerrit-Reviewer: Alexander Wels <aw...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Einav Cohen <eco...@redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
