Roy Golan has posted comments on this change.
Change subject: core: renamed AdUser to LdapUser.
......................................................................
Patch Set 1: (11 inline comments)
minor comments around renaming also args and comments
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/LdapGetAdUserByUserIdListCommand.java
Line 9: import org.ovirt.engine.core.utils.log.Log;
Line 10: import org.ovirt.engine.core.utils.log.LogFactory;
Line 11:
Line 12: /**
Line 13: * This command Responcible to bring large amount of data from Active
Directory with smallest amount of Active directory
this comment also needs to be rephrased if your into it...
Line 14: * Queries. First - all users retrieved from AD. All groups of all
users gathered together. All parent groups of all
Line 15: * groups retrieved by single query. Maximum number of AD queries
equal to AD tree depth + 1(for users query).
Line 16: */
Line 17: public class LdapGetAdUserByUserIdListCommand extends
LdapBrokerCommandBase {
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/LoginBaseCommand.java
Line 98: /**
Line 99: * Handles the user session.
Line 100: *
Line 101: * @param adUser
Line 102: * The ad user.
refactor comments as well
Line 103: */
Line 104: protected void HandleUserSession(LdapUser adUser) {
Line 105: if (!StringUtils.isEmpty(getParameters().getHttpSessionId()))
{
Line 106: user_sessions user_sessions = new user_sessions("", "",
new Date(), "", getParameters()
Line 123: }
Line 124:
Line 125: protected abstract UserAuthenticationResult authenticateUser();
Line 126:
Line 127: protected LdapUser _adUser;
variable names also
Line 128:
Line 129: @Override
Line 130: protected void executeCommand() {
Line 131: // add user session
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UserCommandBase.java
Line 90: *
Line 91: * @param adUser
Line 92: * @return newly create
Line 93: */
Line 94: public static DbUser persistAuthenticatedUser(LdapUser adUser) {
arg name
Line 95: DbUser dbUser =
DbFacade.getInstance().getDbUserDao().get(adUser.getUserId());
Line 96: boolean newUser = dbUser == null;
Line 97: dbUser = new DbUser(adUser);
Line 98: if (newUser) {
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AddUserParameters.java
Line 12: private VdcUser vdcUser;
Line 13:
Line 14: private ad_groups adGroup;
Line 15:
Line 16: private LdapUser adUser;
field name
Line 17:
Line 18: public void setVdcUser(VdcUser vdcUser) {
Line 19: this.vdcUser = vdcUser;
Line 20: }
Line 30: public ad_groups getAdGroup() {
Line 31: return adGroup;
Line 32: }
Line 33:
Line 34: public void setAdUser(LdapUser adUser) {
arg name
Line 35: this.adUser = adUser;
Line 36: }
Line 37:
Line 38: public LdapUser getAdUser() {
Line 34: public void setAdUser(LdapUser adUser) {
Line 35: this.adUser = adUser;
Line 36: }
Line 37:
Line 38: public LdapUser getAdUser() {
you can refactor this in a different patch to make less noise
Line 39: return adUser;
Line 40: }
Line 41:
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/DbUser.java
Line 370: isLoggedIn = value;
Line 371: OnPropertyChanged(new PropertyChangedEventArgs("IsLogedin"));
Line 372: }
Line 373:
Line 374: public DbUser(LdapUser adUser) {
arg name
Line 375: setuser_id(adUser.getUserId());
Line 376: setusername(adUser.getUserName());
Line 377: setname(adUser.getName());
Line 378: setsurname(adUser.getSurName());
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/users/VdcUser.java
Line 28: private String mFirstName;
Line 29: private String mSurName;
Line 30: private boolean mIsAdmin = false;
Line 31:
Line 32: public VdcUser(LdapUser adUser) {
arg name
Line 33: this(adUser, false);
Line 34: }
Line 35:
Line 36: public VdcUser(LdapUser adUser, boolean isAdmin) {
Line 32: public VdcUser(LdapUser adUser) {
Line 33: this(adUser, false);
Line 34: }
Line 35:
Line 36: public VdcUser(LdapUser adUser, boolean isAdmin) {
arg name
Line 37: mUserName = adUser.getUserName();
Line 38: mUserId = adUser.getUserId();
Line 39: mPassword = adUser.getPassword();
Line 40: mDomainControler = adUser.getDomainControler();
....................................................
File
backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/users/VdcUserTest.java
Line 18: public void setUp() {
Line 19: adUser = new LdapUser("UserName", "password", Guid.NewGuid(),
"DomainController");
Line 20: }
Line 21:
Line 22: /** Tests {@link VdcUser#VdcUser(AdUser)) */
javadoc
Line 23: @Test
Line 24: public void testAdUserConstrcutor() {
Line 25: VdcUser user = new VdcUser(adUser);
Line 26: assertFalse("By default, a user should not be an admin",
user.isAdmin());
--
To view, visit http://gerrit.ovirt.org/10014
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I072b276401c7026bae9ee8bdcd6848f431a001a0
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sharad Mishra <snmis...@linux.vnet.ibm.com>
Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com>
Gerrit-Reviewer: Roy Golan <rgo...@redhat.com>
Gerrit-Reviewer: Sharad Mishra <snmis...@linux.vnet.ibm.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
