Yair Zaslavsky has posted comments on this change.
Change subject: core: Rename ad_groups class to LdapGroup
......................................................................
Patch Set 4: (2 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AdGroupsHandlingCommandBase.java
Line 13: import
org.ovirt.engine.core.dal.dbbroker.auditloghandling.CustomLogField;
Line 14: import
org.ovirt.engine.core.dal.dbbroker.auditloghandling.CustomLogFields;
Line 15:
Line 16: @CustomLogFields({ @CustomLogField("AdGroupName") })
Line 17: public abstract class AdGroupsHandlingCommandBase<T extends
AdElementParametersBase> extends CommandBase<T> {
IMHO the class name should be changed.
What do you think?
Line 18: protected tags _tag;
Line 19: private LdapGroup mGroup;
Line 20: private String mGroupName;
Line 21:
....................................................
File
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/AdGroupDAO.java
Line 9: * <code>AdGroupDAO</code> defines a type that performs CRUD operations
on instances of {@link LdapGroup}.
Line 10: *
Line 11: *
Line 12: */
Line 13: public interface AdGroupDAO extends DAO {
Please rename Daos.
Yes, we are still stuck with the table name, but let's minimize the presence of
"AD" in our code.
Line 14: /**
Line 15: * Retrieves the instance with the specified id.
Line 16: *
Line 17: * @param id
--
To view, visit http://gerrit.ovirt.org/9835
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic2429b55981a18cbb8fc9ceaf33d949195d66d8c
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sharad Mishra <snmis...@linux.vnet.ibm.com>
Gerrit-Reviewer: Laszlo Hornyak <lhorn...@redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpast...@redhat.com>
Gerrit-Reviewer: Moti Asayag <masa...@redhat.com>
Gerrit-Reviewer: Sharad Mishra <snmis...@linux.vnet.ibm.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
