ofri masad has posted comments on this change. Change subject: core: Added "scan" to disks resource to import clones ......................................................................
Patch Set 1: (1 inline comment) .................................................... File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java Line 106: RemoveSnapshot(210, ActionGroup.MANIPULATE_VM_SNAPSHOTS, QuotaDependency.STORAGE), Line 107: RemoveImage(211, QuotaDependency.STORAGE), Line 108: RemoveAllVmImages(212, QuotaDependency.STORAGE), Line 109: AddImageFromScratch(213, QuotaDependency.STORAGE), Line 110: ImportImage(214, ActionGroup.CONFIGURE_VM_STORAGE, QuotaDependency.STORAGE), It is importing the information about an existing image - that's true. But by doing so you actually allow using of image in ovirt without counting this image in the Quota mechanism. Consider the following scenario: you have a disk of 20GB. you copy that disk and then import it (without telling the Quota mechanism). you now have a 20GB disk which you can add to VM and which you never "payed" for. This should remain STORAGE Line 111: RemoveTemplateSnapshot(215, QuotaDependency.STORAGE), Line 112: RemoveAllVmTemplateImageTemplates(216, QuotaDependency.STORAGE), Line 113: TryBackToAllSnapshotsOfVm(223, ActionGroup.MANIPULATE_VM_SNAPSHOTS, QuotaDependency.NONE), Line 114: RestoreAllSnapshots(224, ActionGroup.MANIPULATE_VM_SNAPSHOTS, QuotaDependency.STORAGE), -- To view, visit http://gerrit.ovirt.org/9603 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If6236e563d38ee1a793bd94ff60587f19b3010d1 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Chris Morrissey <cmorr...@netapp.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Ayal Baron <aba...@redhat.com> Gerrit-Reviewer: Chris Morrissey <cmorr...@netapp.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com> Gerrit-Reviewer: Eduardo <ewars...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Michael Pasternak <mpast...@redhat.com> Gerrit-Reviewer: Ori Liel <ol...@redhat.com> Gerrit-Reviewer: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: ofri masad <oma...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
