Allon Mureinik has uploaded a new change for review.
Change subject: core: ImportVm cleanup: CDA_beforeCloneVm sig.
......................................................................
core: ImportVm cleanup: CDA_beforeCloneVm sig.
Stop passing canDoAction to canDoAction_beforeCloneVm, as it is
available as a datamember, and does not contribute anything as a
parameter.
Change-Id: I31ff56cd187510ed48c3be66a82b09337e2588bf
Signed-off-by: Allon Mureinik <amure...@redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java
1 file changed, 3 insertions(+), 2 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/06/10006/1
diff --git
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java
index db2d3f8..ba5162d 100644
---
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java
+++
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java
@@ -129,7 +129,7 @@
boolean retVal = true;
List<String> canDoActionMessages =
getReturnValue().getCanDoActionMessages();
Map<Guid, storage_domains> domainsMap = new HashMap<Guid,
storage_domains>();
- retVal = canDoAction_beforeCloneVm(canDoActionMessages, domainsMap);
+ retVal = canDoAction_beforeCloneVm(domainsMap);
if (retVal && getParameters().isImportAsNewEntity()) {
initImportClonedVm();
@@ -156,7 +156,8 @@
}
}
- private boolean canDoAction_beforeCloneVm(List<String>
canDoActionMessages, Map<Guid, storage_domains> domainsMap) {
+ private boolean canDoAction_beforeCloneVm(Map<Guid, storage_domains>
domainsMap) {
+ List<String> canDoActionMessages =
getReturnValue().getCanDoActionMessages();
if (getVm() != null) {
setDescription(getVmName());
--
To view, visit http://gerrit.ovirt.org/10006
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I31ff56cd187510ed48c3be66a82b09337e2588bf
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amure...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
