Allon Mureinik has uploaded a new change for review.
Change subject: core: ImportVm cleanup: CDA_afterCloneVm signature
......................................................................
core: ImportVm cleanup: CDA_afterCloneVm signature
Stop passing canDoActionMessages to canDoAction_afterCloneVm, as it is
available as a datamember, and does not contribute anything as a
parameter.
Change-Id: I83c7a8cde592cd8f69943b90d1ed17e3797e856b
Signed-off-by: Allon Mureinik <amure...@redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java
1 file changed, 3 insertions(+), 4 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/07/10007/1
diff --git
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java
index 16f21bd..51102d0 100644
---
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java
+++
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java
@@ -127,7 +127,6 @@
@Override
protected boolean canDoAction() {
boolean retVal = true;
- List<String> canDoActionMessages =
getReturnValue().getCanDoActionMessages();
Map<Guid, storage_domains> domainsMap = new HashMap<Guid,
storage_domains>();
retVal = canDoAction_beforeCloneVm(domainsMap);
@@ -135,7 +134,7 @@
initImportClonedVm();
}
- return retVal && canDoAction_afterCloneVm(canDoActionMessages,
domainsMap);
+ return retVal && canDoAction_afterCloneVm(domainsMap);
}
@Override
@@ -271,7 +270,7 @@
canDoActionMessages);
}
- private boolean canDoAction_afterCloneVm(List<String> canDoActionMessages,
Map<Guid, storage_domains> domainsMap) {
+ private boolean canDoAction_afterCloneVm(Map<Guid, storage_domains>
domainsMap) {
VM vm = getParameters().getVm();
// check that the imported vm guid is not in engine
@@ -302,7 +301,7 @@
if
(!ImagesHandler.CheckImageConfiguration(domainsMap.get(imageToDestinationDomainMap.get(key.getId()))
.getStorageStaticData(),
(DiskImageBase) disk,
- canDoActionMessages)) {
+ getReturnValue().getCanDoActionMessages())) {
return false;
}
}
--
To view, visit http://gerrit.ovirt.org/10007
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I83c7a8cde592cd8f69943b90d1ed17e3797e856b
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amure...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
