Einav Cohen has posted comments on this change.
Change subject: webadmin: Added the ability to define a 'no items' message.
......................................................................
Patch Set 4: (1 inline comment)
....................................................
File
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java
Line 2434: String detachGlusterHostsHostAddress();
Line 2435:
Line 2436: @DefaultStringValue("Detach the hosts forcefully")
Line 2437: String detachGlusterHostsForcefully();
Line 2438:
Alex, there should be no translation-related problems if we are going with
Daniel's approach.
As long as the sentence is a full sentence and the nature of the parameter is
the same for all use-cases (in our case, the parameter value is always a name
of a business-entity type), we should be OK.
Can you please update the patch according to Daniel's suggestion? We might
actually automatically gain for free some more "strongly-typed" "no x to
display" messages for some of the grids in the sub-tabs that might haven't been
taken care of in your original patch, etc. Thanks.
Line 2439: //No items to display messages.
Line 2440: @DefaultStringValue("No Data Centers to display")
Line 2441: String noDataCentersToDisplay();
Line 2442:
--
To view, visit http://gerrit.ovirt.org/9830
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If808e7c1bc92877d3f59b766985900a2c8ffd216
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alexander Wels <aw...@redhat.com>
Gerrit-Reviewer: Alexander Wels <aw...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Einav Cohen <eco...@redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
