Allon Mureinik has posted comments on this change. Change subject: engine: search does not complete boolean fields values ......................................................................
Patch Set 2: Looks good to me, but someone else must approve (1 inline comment) The code looks fine to me, but please fix the commit message when you rebase .................................................... Commit Message Line 3: AuthorDate: 2012-11-19 14:33:16 -0500 Line 4: Commit: Ravi Nori <rn...@redhat.com> Line 5: CommitDate: 2012-12-09 18:52:36 +0200 Line 6: Line 7: engine: search does not complete boolean fields values This title is not descriptive of the patch, and actually, is not correct. How about: "engine: search disks does not complete bootable and shareable", or something down those lines? Line 8: Line 9: Search engine does not complete values for boolean fields Line 10: like Disks : bootable = and Disks : shareable = Line 11: -- To view, visit http://gerrit.ovirt.org/9341 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia0a3a9c1fa6186c426d764afd11875e80478912b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
