Omer Frenkel has posted comments on this change. Change subject: engine: Introducing a queue for failovers event ......................................................................
Patch Set 1: (1 inline comment) what about calls to reconstruct (and other relevant commands) not from the event listener? means from the bll commands? shouldn't use the 'events' as well? .................................................... Commit Message Line 12: The appropriate event should be submitted to queue and will be executed accorrding to Line 13: internal logic of queue. Line 14: Because of execution of events is done in separate thread no deadlock should occurred, also Line 15: no need for excplicit additional locking Line 16: These is a first patch it will introduce a queue and all stuff should work as before, but i guess it should be 'This' Line 17: using of queue with small change will allow: to reject unneeded events when some othe event is running, Line 18: ensure order, ensure appropriate release of quartz threads, fix a races Line 19: Line 20: Change-Id: Ic1224feacdcdaaaf0b59d26105805ba7ef2a2fff -- To view, visit http://gerrit.ovirt.org/9838 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic1224feacdcdaaaf0b59d26105805ba7ef2a2fff Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <mkub...@redhat.com> Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
